Closed Bug 1373988 Opened 7 years ago Closed 7 years ago

Build fails with system-libvpx and system-jpeg enabled in mozconfig

Categories

(Firefox Build System :: General, defect)

55 Branch
defect
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: shalokshalom, Assigned: dminor)

References

Details

Attachments

(2 files, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0 Build ID: 20170613173134 Steps to reproduce: Build with the default mozconfig on KaOS or Arch - i guess others are also effected Actual results: This error message(s) appeared (USE_LIBS contains (media_libjpeg) / (media_libvpx) which does not match any LIBRARY_NAME in the tree.) Expected results: Build finished fine.
Component: Untriaged → Build Config
Product: Firefox → Core
Attached file mozconfig (deleted) —
mozconfig file with the mentioned entries commented out
https://dxr.mozilla.org/mozilla-beta/rev/b08a305464d127e25fab19f358fac15fceb52954/media/webrtc/trunk/gtest/moz.build#29,31 > USE_LIBS += [ > ... > 'media_libjpeg', > ... > 'media_libvpx', I guess these lines should be inside a branch on CONFIG['MOZ_SYSTEM_JPEG'] or CONFIG['MOZ_SYSTEM_LIBVPX'].
Blocks: 964133
Assignee: nobody → dminor
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8879131 - Flags: review?(mh+mozilla)
Comment on attachment 8879131 [details] [diff] [review] Check for system libjpeg and libvpx in webrtc gtest moz.build Review of attachment 8879131 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/webrtc/trunk/gtest/moz.build @@ +43,5 @@ > 'yuv', > ] > > +if not CONFIG['MOZ_SYSTEM_JPEG']: > + USE_LIBS += ['media_libjpeg'] That will still fail, albeit with a different error, because of the missing linkage of the system jpeg and vpx libraries. I think we need something similar to what's done with config/external/*/moz.build (e.g. sqlite)
Attachment #8879131 - Flags: review?(mh+mozilla)
Yes, I foolishly didn't let the build run to completion once I saw it get past the errors mentioned. This patch does build on my (Ubuntu) system both with and without --with-system-jpeg and --with-system-libvpx set.
Attachment #8879131 - Attachment is obsolete: true
Attachment #8879503 - Flags: review?(mh+mozilla)
Comment on attachment 8879503 [details] [diff] [review] Check for system libjpeg and libvpx in webrtc gtest moz.build Review of attachment 8879503 [details] [diff] [review]: ----------------------------------------------------------------- This fixes the immediate problem, but I still think we need something like config/external/sqlite/moz.build. Please file a followup bug.
Attachment #8879503 - Flags: review?(mh+mozilla) → review+
Thanks! Filed Bug 1375178.
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bc36447fcf4 Make webrtc-gtest build work with system jpeg and libvpx; r=glandium
We'll want this uplifted to beta. Can you do the request?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: