Closed Bug 1374056 Opened 7 years ago Closed 7 years ago

toolkit/content/tests/chrome/test_bug437844.xul and layout/xul/test/test_bug393970.xul assertion count is greater than expected

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: sparky, Assigned: sparky)

References

Details

Attachments

(1 file)

Bug 1374056 - Decrease assertion count test_bug393970.xul and test_bug437844.xul and increase expected range.
(deleted), text/x-review-board-request
jmaher
: review+
Details
When running mochitest-chrome on ubuntu 16, there are many more assertions that start to occur. The additional assertions in toolkit/content/tests/chrome/test_bug437844.xul are intermittent, and layout/xul/test/test_bug393970.xul is almost a perma-failure. Here's a link to a test run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c74afcf988a46f76c1360625042384013e74d0c7&selectedJob=107505952 The first chunk for linux debug has both failures.
Component: XUL Widgets → General
Comment on attachment 8878902 [details] Bug 1374056 - Decrease assertion count test_bug393970.xul and test_bug437844.xul and increase expected range. https://reviewboard.mozilla.org/r/150150/#review155060 I think the cpp changes are good, but I don't see a try run for including the assertion changes.
Attachment #8878902 - Flags: review?(jmaher) → review-
I added the assertion count change afterwards because the cpp change wasn't enough for that test. You can see the failure here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c041857b1b070070326b1cd71e1abdbbc3f340e&selectedJob=107997683 Want me to start another run with this patch to be sure?
Flags: needinfo?(jmaher)
yes, please try another run!
Flags: needinfo?(jmaher)
Here's the newest try run with the correct patch applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc414f3abdbf6c1b8de300fc34e40f485342d2e1 Only a few tests left to go.
Once it's done, I'll submit a patch for review if all is well.
Comment on attachment 8878902 [details] Bug 1374056 - Decrease assertion count test_bug393970.xul and test_bug437844.xul and increase expected range. https://reviewboard.mozilla.org/r/150150/#review155262
Attachment #8878902 - Flags: review?(jmaher) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9dcc46eb2846 Decrease assertion count test_bug393970.xul and test_bug437844.xul and increase expected range. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/9dcc46eb2846
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → gmierz2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: