Nils Ohlmeier [:drno] Assignee
	Description • 7 years ago

      No description provided.

	Randell Jesup [:jesup] (needinfo me)
	Comment 2 • 7 years ago
mozreview-review

Comment on attachment 8879310 [details]
Bug 1374440: stop sending max-message-size.

https://reviewboard.mozilla.org/r/150586/#review155334

	Pulsebot
	Comment 3 • 7 years ago

Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/a60b36252622
stop sending max-message-size. r=jesup

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 4 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a60b36252622

	Nils Ohlmeier [:drno] Assignee
	Comment 5 • 7 years ago

Comment on attachment 8879310 [details]
Bug 1374440: stop sending max-message-size.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335262
[User impact if declined]: The signaling emitted through bug 1335262 needs to be emitted only when bug 979417 lands to allow us detecting that the feature in bug 979417 is available. So without this patch WebRTC data channels might not work between different Firefox versions any more.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It only turns off emitting a single thing in WebRTC's signaling, which Firefox did not used to emit before landing bug 1335262.
[String changes made/needed]: N/A

	Julien Cristau [:jcristau]
	Comment 6 • 7 years ago

Comment on attachment 8879310 [details]
Bug 1374440: stop sending max-message-size.

webrtc fix for beta55

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/a48ce5c2f87a

	Cornel Ionce [:noni] [Hubs QA]
	Comment 8 • 7 years ago

Based on comment 5, this does not manual coverage. 
Updating the qe‑verify flag to reflect this.