Closed
Bug 1374777
Opened 7 years ago
Closed 7 years ago
setResourceTimingBufferSize shouldn't affect user timing
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
DUPLICATE
of bug 1159003
People
(Reporter: clarkbw, Assigned: baku)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review-
|
Details | Diff | Splinter Review |
Coming from bug 1159003
The perf API function setResourceTimingBufferSize is designed for ResourceTiming yet the Firefox implementation seems to be effecting UserTiming either as well or instead.
See also:bug 1159003 Comment 8 and https://github.com/w3c/resource-timing/issues/89
|
Assignee | |
Comment 2•7 years ago
|
||
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8887093 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•7 years ago
|
||
We don't need to have a weakreference for addObserver.
Attachment #8887093 -
Attachment is obsolete: true
Attachment #8887093 -
Flags: review?(bzbarsky)
Attachment #8887489 -
Flags: review?(bzbarsky)
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8887489 [details] [diff] [review]
perfomance.patch
This patch should be on bug 1159003, not this bug, right? That's where all the relevant discussion is.
You relly want QI to nsISupports to produce the same pointer as GetAsISupports, I would think. Why is that not happening?
>+ if (!strcmp(aTopic, "inner-window-destroyed")) {
This makes destroying N inner windows O(N^2), since each one will have a performance object, right? Is there a reason we're not just having the window notify its (one) performance object when it would send that notification?
>+ uint64_t mInnerID;
Needs documentation.
Attachment #8887489 -
Flags: review?(bzbarsky) → review-
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•