Closed Bug 1374815 Opened 7 years ago Closed 7 years ago

Sidebar switcher menu items need updated hover styling

Categories

(Firefox :: Menus, defect, P1)

Product:
Firefox
Component:
Menus
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: abenson, Assigned: Gijs)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [photon-structure])

Attachments

(2 files)

menu_hovers.png
(deleted), image/png
Details
Bug 1374815 - fix sidebar hover styling and unify photon styling with the default,
(deleted), text/x-review-board-request
nhnt11
: review+
Details
Attached image menu_hovers.png (deleted) —
The hover states for the menu items in the sidebar switcher menu (popout) need to be updated to match other Photon menu styles. Reference here: https://mozilla.invisionapp.com/share/PYC5LJJXG#/229940647_Toolbars
Flags: qe-verify?
Whiteboard: [photon-structure] → [photon-structure] [triage]
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly
Blocks: 1387512
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
Priority: P2 → P1
Attachment #8900235 - Flags: review?(dao+bmo) → review?(nhnt11)
Depends on: 1373961
(Switched reviewers because it looks like Dão's queue is quite full)
Comment on attachment 8900235 [details] Bug 1374815 - fix sidebar hover styling and unify photon styling with the default, https://reviewboard.mozilla.org/r/171614/#review178296
Attachment #8900235 - Flags: review?(nhnt11) → review+
Comment on attachment 8900235 [details] Bug 1374815 - fix sidebar hover styling and unify photon styling with the default, https://reviewboard.mozilla.org/r/171614/#review178298 Changes look alright to me. Obviously we can file follow-ups if we missed anything. I tested the patch locally too and thing seem good.
Iteration: 57.2 - Aug 29 → 57.3 - Sep 19
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s a6970bd2f1b5 -d 5558134ce16b: rebasing 416554:a6970bd2f1b5 "Bug 1374815 - fix sidebar hover styling and unify photon styling with the default, r=nhnt11" (tip) merging browser/themes/linux/customizableui/panelUI.css merging browser/themes/shared/customizableui/panelUI.inc.css warning: conflicts while merging browser/themes/linux/customizableui/panelUI.css! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4fb65ac5a587 fix sidebar hover styling and unify photon styling with the default, r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/4fb65ac5a587
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
This bug fix is verified on the latest nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
No longer depends on: 1397086
Depends on: 1397754
Depends on: 1399145
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: