Closed
Bug 1374902
Opened 7 years ago
Closed 7 years ago
stylo: Have unprefixed :fullscreen pseudo-class guarded behind full-screen-api.unprefix.enabled
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
:fullscreen pseudo-class should not take effect in document stylesheet if unprefixed Fullscreen API is not enabled. It seems there is no test currently checking this. We should also add a test to dom/html/test/file_fullscreen-unprefix-disabled.html to ensure we check this properly.
Assignee | ||
Comment 2•7 years ago
|
||
We don't want to unintentionally ship unprefixed Fullscreen things.
Blocks: 1337166
Priority: -- → P2
Assignee | ||
Comment 3•7 years ago
|
||
This is something I'm familiar with. I would take care of this.
Assignee: nobody → xidorn+moz
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Attachment #8892749 -
Flags: review?(cam) → review?(tlin)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8892749 [details] Bug 1374902 - Check pref when parsing :fullscreen pseudo-class. https://reviewboard.mozilla.org/r/163740/#review169798 This looks good to me. However, I just landed bug 1381851 which conflict with this patch. You'll need to rebase. Sorry about that. Also, gecko uses CSS_PSEUDO_CLASS_ENABLED_IN_UA_SHEETS_AND_CHROME for :fullscreen at [1]. I left a comment on servo at [2]. You might want to add it accordingly if it's suitable, and remove the TODOs. [1] http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/layout/style/nsCSSPseudoClassList.h#173 [2] https://github.com/servo/servo/blob/585c00f23559e9cf5dea288852515fd001bc1c43/components/style/gecko/non_ts_pseudo_class_list.rs#L64-L66
Attachment #8892749 -
Flags: review?(tlin)
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8892749 [details] Bug 1374902 - Check pref when parsing :fullscreen pseudo-class. https://reviewboard.mozilla.org/r/163740/#review173294 Sorry for the delay. This looks good to me!
Attachment #8892749 -
Flags: review?(tlin) → review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/970be3668e1e Check pref when parsing :fullscreen pseudo-class. r=TYLin
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/970be3668e1e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•