Closed
Bug 1374938
Opened 7 years ago
Closed 7 years ago
mediaDevices.ondevicechange and cam contraints are broken on Mac OSX
Categories
(Core :: WebRTC: Audio/Video, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | fixed |
People
(Reporter: mchiang, Assigned: mchiang)
References
Details
(Keywords: regression)
Attachments
(1 file)
The code update introduced in bug 1341285 broke mediaDevices.ondevicechange on Mac OSX. It is because we are now using webrtc.org's avfoundation wrapper under the folder video_capture/objc instead of our own implementation under video_capture/mac.
|
||
Updated•7 years ago
|
Rank: 25
Priority: -- → P2
|
||
Comment 1•7 years ago
|
||
It seems difficult to have a test case for device change since it is hard to simulate it. It would be nice to have a test case to avoid this kind of regression.
|
||
Updated•7 years ago
|
|
||
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mchiang
|
|
||
Updated•7 years ago
|
Summary: mediaDevices.ondevicechange is broken on Mac OSX → mediaDevices.ondevicechange and cam contraints are broken on Mac OSX
|
|
||
Comment 4•7 years ago
|
||
(In reply to Blake Wu [:bwu][:blakewu] from comment #1)
> It seems difficult to have a test case for device change since it is hard to
> simulate it. It would be nice to have a test case to avoid this kind of
> regression.
While device changes are hard to test camera constraints might be a little bit easier.
I guess the problem with the constraints is that we use the fake camera everywhere/mostly(?).
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8880257 [details]
Bug 1374938 - use our own avfoundation wrapper.
https://reviewboard.mozilla.org/r/151614/#review156984
lgtm.
Attachment #8880257 -
Flags: review?(jib) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/c846596b4cb8
use our own avfoundation wrapper. r=jib
Keywords: checkin-needed
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
status-firefox54:
--- → unaffected
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•