Closed
Bug 1375040
Opened 7 years ago
Closed 7 years ago
Use defineLazyPreferenceGetter for toolkit.cosmeticAnimations.enabled in tabbrowser.xml since we check the pref in multiple places
Categories
(Firefox :: Tabbed Browser, enhancement, P1)
Firefox
Tabbed Browser
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [reserve-photon-animation])
Attachments
(1 file)
From a review comment in bug 1366060,
> ::: browser/base/content/tabbrowser.xml:7042
> (Diff revision 1)
> > let dropIndex = "animDropIndex" in draggedTab._dragData &&
> > draggedTab._dragData.animDropIndex;
> > if (dropIndex && dropIndex > draggedTab._tPos)
> > dropIndex--;
> >
> > - if (oldTranslateX && oldTranslateX != newTranslateX) {
> > + let animate = Services.prefs.getBoolPref("toolkit.cosmeticAnimations.enabled");
>
> We check this pref in 2 other places already. Maybe we should just have a
> defineLazyPreferenceGetter() on the tabbrowser for this?
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8880029 [details]
Bug 1375040 - Use defineLazyPreferenceGetter for toolkit.cosmeticAnimations.enabled in tabbrowser.xml since we check the pref in multiple places.
https://reviewboard.mozilla.org/r/151368/#review156298
Attachment #8880029 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17a1967006d4
Use defineLazyPreferenceGetter for toolkit.cosmeticAnimations.enabled in tabbrowser.xml since we check the pref in multiple places. r=Gijs
|
||
Updated•7 years ago
|
Iteration: --- → 56.1 - Jun 26
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [reserve-photon-animation]
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
|
||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•