Closed
Bug 1375168
Opened 7 years ago
Closed 7 years ago
make llvm-config check also check ~/.mozbuild/ location chosen by `mach bootstrap`
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
We need to do this so most users will not have to add anything special to their mozconfig once they have run `mach bootstrap`: the build system will detect the installed bits automatically.
![]() |
Assignee | |
Comment 1•7 years ago
|
||
For ease of use, we want to make checks for llvm-config automatically examine the directory where `mach bootstrap` would install things, so users don't necessarily have to have a mozconfig when building stylo. Since the computation of this value is non-trivial, we pull out the whole list of possible names for llvm-config into a @depends function, and insert the computed value into that list when necessary.
Attachment #8880123 -
Flags: review?(giles)
Comment 2•7 years ago
|
||
Comment on attachment 8880123 [details] [diff] [review] check for llvm-config where `mach bootstrap` would install it Review of attachment 8880123 [details] [diff] [review]: ----------------------------------------------------------------- I was just wondering about this!
Attachment #8880123 -
Flags: review?(giles) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7a99f0444e21 check for llvm-config where `mach bootstrap` would install it; r=rillian
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7a99f0444e21
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•