Closed Bug 1375197 Opened 7 years ago Closed 6 years ago

[aws-provisioner] Remove support for worker type secrets from AWS provisioner

Categories

(Taskcluster :: Services, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pmoore, Assigned: dustin)

References

Details

(Whiteboard: good-first-bug)

Once bug 1375195 has been completed, we should be safe to remove support for worker type secrets from the provisioner. I'd prefer to do this before making worker types publicly viewable, since it solves the race-condition problem that we validate no worker types are using secrets, then during the process of making the worker types publicly world-readable, a new worker type is added e.g. from an old template, that suddenly exposes confidential secrets. This is quite a realistic disclosure possibility, and therefore by removing the feature before exposing the worker type definitions, we are sure no secrets exist.
Blocks: 1375199
Blocks: 1375200
Blocks: 1375201
No longer blocks: 1375155
Summary: Remove support for worker type secrets from AWS provisioner → [aws-provisioner] Remove support for worker type secrets from AWS provisioner
Assignee: nobody → pmoore
Will look at this soon...
Having this implemented would be great, especially since we're doing work to derive taskcluster credentials from instance identity documents. These credentials aren't planned to have support for provisioner secrets.
This should be done as a part of the worker-manager transition. Since we'll deprecate the aws-provisioner codebase in favour of the worker manager, we should do the work in this bug. That said, we should still work through bug 1375200 and bug 1375201
Component: AWS-Provisioner → Generic-Worker
QA Contact: pmoore
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
reopening this bug, removing worker secrets shouldn't be too difficult from the aws-provisioner codebase, so we should probably consider doing it.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
No longer blocks: 1375200
Depends on: 1375200
No longer blocks: 1375201
Depends on: 1375201
Component: Generic-Worker → Workers
Component: Workers → Services
Assignee: pmoore → nobody
Whiteboard: good-first-bug
Assignee: nobody → dustin
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.