Closed Bug 1375456 Opened 7 years ago Closed 7 years ago

unable to run mach talos-test -a quantum_pageload_X due to nonlocal network connection

Categories

(Testing :: Talos, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jmaher, Assigned: rwood)

Details

(Whiteboard: [PI:June])

Attachments

(1 file)

we should ensure that we disable this for quantum or figure out how to add an exception to the proxy.
How did this change? I was disabling it for the quantum-pageload test.
I probably re-enabled it for all talos- lets figure out how to disable it for quantum specifically: https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/ffsetup.py?q=path%3Affsetup.py&redirect_type=single#72 that makes sense as to why this was not set!
Whiteboard: [PI:June]
Hmmm yeah it's being set here in ttest, just for quantum-pageload but it must be overwritten somewhere else: http://searchfox.org/mozilla-central/source/testing/talos/talos/ttest.py#110
possibly this is during the profile warmup where the problem is, that is where I added the env var in order to try to fix the webext stuff, despite marionette not working.
Interesting, I can't reproduce this. I pulled the latest central onto my local Win 10 test box, did a build, and the talos quantum-pageload-e10s tests ran fine (mach talos-test --suite quantum-pageload-e10s). All the mitmproxy pages are loaded (and results reported).
Oh wait I just noticed you use -a to run each test separate, ok right. Did you add the --mitmproxy argument on the command line also?
i.e. this works on my Win10 box: mach talos-test -a quantum_pageload_google --mitmproxy mitmproxy-recording-google.mp
where would you get mitmproxy-recording-google.mp ?
The file itself will be downloaded automatically (inside the playback archive). This same command line is automatically set in in the talos.json talos_optios for the quantum-pageload-e10s test. Maybe I should add code to have talos grab that if someone tries to run one of the quantum_pageload_* tests just via -a and not expect it on the command line.
Assignee: nobody → rwood
Status: NEW → ASSIGNED
+1 for that
Comment on attachment 8881297 [details] Bug 1375456 - Fix running talos quantum_pageload_* tests locally with -activeTests; https://reviewboard.mozilla.org/r/152498/#review157890 thanks!
Attachment #8881297 - Flags: review?(jmaher) → review+
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e2b8234a6b5 Fix running talos quantum_pageload_* tests locally with -activeTests; r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: