This bug was filed from the Socorro interface and is report bp-b29e4894-3fb0-45f4-acc9-135f70170622. ============================================================= CRT tearing down the blocklist's NtDllIntercept? We should probably leak this one.

Odd mix here... Reason facet 1 EXCEPTION_ACCESS_VIOLATION_WRITE 24 43.64 % 2 EXCEPTION_ACCESS_VIOLATION_READ 19 34.55 % 3 EXCEPTION_ILLEGAL_INSTRUCTION 7 12.73 % 4 EXCEPTION_PRIV_INSTRUCTION 5 9.09 %

(100.0% in signature vs 07.54% overall) Module "plugin-container.exe" = true [138.46% vs 22.16% if startup_crash = null] I guess we could just avoid these hooks for plugin-container, they're not necessary.

It turns out the gecko profiler does run in plugin-container, so in general we would still need those hooks there. But since we're not aware of anyone actually using the profiler for plugin-container, we could turn it off by default and remove the hooks. Markus suggested creating a pref and making SendInitProfiler conditional on it in http://searchfox.org/mozilla-central/source/dom/plugins/ipc/PluginModuleParent.cpp#633.

(In reply to David Major [:dmajor] from comment #3) > It turns out the gecko profiler does run in plugin-container, so in general > we would still need those hooks there. But since we're not aware of anyone > actually using the profiler for plugin-container, we could turn it off by > default and remove the hooks. Markus suggested creating a pref and making > SendInitProfiler conditional on it in > http://searchfox.org/mozilla-central/source/dom/plugins/ipc/ > PluginModuleParent.cpp#633. Would you be okay with me just sticking a Preferences::GetBool one-liner here, or do I need to make this a more formal pref? I really don't expect anyone other than #flow inhabitants will ever use it, if at all.

Nevermind; this is probably the same root cause as all the other update/exit bugs this week, and I'll need to fix things more generally.

I believe this should be fixed in build 20170706. Let's see what crash-stats says after a few days.

(In reply to David Major [:dmajor] from comment #6) > I believe this should be fixed in build 20170706. Let's see what crash-stats > says after a few days. Confirmed - no hits as of that date.