This happen to uncover the fact that mingw clang was not handled properly after bug 1372987. This will allow us to substantially modify the function that handles them and avoid regressions. Review commit: https://reviewboard.mozilla.org/r/152132/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/152132/

SO_VERSION has only an impact on those builds. Also set the default at the option level, instead of doing that in the library_name_info function. Review commit: https://reviewboard.mozilla.org/r/152134/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/152134/

The function as it currently is matches how things were done in old-configure.in. However, that's just confusing and hard to follow. In fact, the unit test failing numerous times while writing this patch pretty much highlights the problem. So instead of a confusing set of overrides to the prefixes and suffixes, spell out the whole set for each set of platforms. This also happens to make the function shorter. Win/win. At the same time, we normalize the function output as a nested namespace, where we get, for each of dll, lib, import_lib, etc. a prefix/suffix pair. Further down the road, we can imagine changing those to class instances with a method allowing to format file names based on those prefix/suffixes. Review commit: https://reviewboard.mozilla.org/r/152136/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/152136/

We eventually want to templatize the library_name_info function, in order to have one for host and one for target. So we don't want 3 different dependencies for the target. Review commit: https://reviewboard.mozilla.org/r/152138/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/152138/

The libclang test wants to find a libclang library for use for rust bindgen. But that's a host process, that needs a host libclang. However, we currently only have the target library/object prefix/suffixes. This works fine... except when cross-compiling. So we need to figure out the proper ones for the host, and use those instead. For that, we templatize library_name_info in order to get a separate set of library/object prefix/suffixes for the host and the target. And we use the host set for the libclang check. Ideally, the build system would also use the host set for host tools builds, but we'll leave that to a followup. Review commit: https://reviewboard.mozilla.org/r/152140/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/152140/

Comment on attachment 8880760 [details] Bug 1375798 - Add a unit test for library/object prefix/suffixes. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152132/diff/1-2/

Comment on attachment 8880761 [details] Bug 1375798 - Limit the SO_VERSION option to openbsd builds. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152134/diff/1-2/

Comment on attachment 8880762 [details] Bug 1375798 - Reorganize the library_name_info function. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152136/diff/1-2/

Comment on attachment 8880763 [details] Bug 1375798 - Avoid using target_is_windows and target_is_darwin in library_name_info. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152138/diff/1-2/

Comment on attachment 8880764 [details] Bug 1375798 - Figure out host library/object prefix/suffixes and use them for libclang. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152140/diff/1-2/