Closed Bug 1376100 Opened 7 years ago Closed 7 years ago

[hamburger panel][Linux] Icon is misaligned in icon-only buttons (without labels) like cut, copy, paste, zoom in/out, sync now and the fullscreen button

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Flags:
Tracking Status
firefox56 --- verified

People

(Reporter: dao, Assigned: Gijs)

References

Details

(Whiteboard: [photon-structure])

Attachments

(2 files)

screenshot
(deleted), image/png
Details
Bug 1376100 - icons in hamburger panels have too much end-margin causing misalignment,
(deleted), text/x-review-board-request
dao
: review+
Details
Attached image screenshot (deleted) —
The affects Sync Now, Zoom In, Zoom Out, Fullscreen, Cut, Copy, and Paste items.
Summary: [hamburger panel] Icon is misaligned within items without labels → [hamburger panel][Linux] Icon is misaligned in icon-only buttons (without labels) like cut, copy, paste, zoom in/out, sync now and the fullscreen button
Whiteboard: [photon-structure][triage] → [photon-structure]
Flags: qe-verify?
Priority: -- → P2
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly
This turns out to all be because of one CSS rule. :-)
Assignee: nobody → gijskruitbosch+bugs
Blocks: 1375864
Status: NEW → ASSIGNED
Iteration: --- → 56.2 - Jul 10
Priority: P2 → P1
Comment on attachment 8882211 [details] Bug 1376100 - icons in hamburger panels have too much end-margin causing misalignment, https://reviewboard.mozilla.org/r/153312/#review158530
Attachment #8882211 - Flags: review?(dao+bmo) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6b2201c843e1 icons in hamburger panels have too much end-margin causing misalignment, r=dao
https://hg.mozilla.org/mozilla-central/rev/6b2201c843e1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Verified on Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: