Closed
Bug 1376163
Opened 7 years ago
Closed 7 years ago
[10.13] No audio playback on YouTube, no audio/video on Netflix (macOS High Sierra 10.13 Beta)
Categories
(Core :: Security: Process Sandboxing, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla56
People
(Reporter: soeren.hentzschel, Assigned: haik)
References
Details
(Whiteboard: sb+)
Attachments
(4 files)
(deleted),
text/x-review-board-request
|
Alex_Gaynor
:
review+
|
Details |
(deleted),
patch
|
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Alex_Gaynor
:
review+
jcristau
:
approval-mozilla-release-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Alex_Gaynor
:
review+
jcristau
:
approval-mozilla-esr52+
|
Details | Diff | Splinter Review |
On macOS High Sierra Developer Beta 2 there is no sound on YouTube videos. The issue was also present in Developer Beta 1. It's reproducible with a new Firefox profile on every release channel.
Updated•7 years ago
|
Component: Audio/Video: Playback → Audio/Video: cubeb
Updated•7 years ago
|
Rank: 14
Priority: -- → P1
Same problem. No audio. Also, Nightly is not indicating or recognizing updates. Have to download them manually.
Comment 2•7 years ago
|
||
Soren,
Can you try to disable e10s (from "Preference" -> "Enable multi-process") to see if this problem disappears?
Bug 1372825 could has the same problem.
Updated•7 years ago
|
Comment 4•7 years ago
|
||
Can someone try to re-enable e10s, and go to about:config, set "security.sandbox.content.level" to "0", restart the browser, and try again ?
Comment 6•7 years ago
|
||
Bob, any idea here? See comment 4. This breaks audio playback on 10.13.
Flags: needinfo?(bobowencode)
Updated•7 years ago
|
"Can someone try to re-enable e10s, and go to about:config, set "security.sandbox.content.level" to "0", restart the browser, and try again ?"
This fixed my audio High Sierra beta 2.
Comment 9•7 years ago
|
||
Haik will be a better person to answer this.
Flags: needinfo?(bobowencode) → needinfo?(haftandilian)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → haftandilian
Flags: needinfo?(haftandilian)
Comment 10•7 years ago
|
||
(In reply to Paul Adenot (:padenot) from comment #4)
> Can someone try to re-enable e10s, and go to about:config, set
> "security.sandbox.content.level" to "0", restart the browser, and try again ?
Confirmed that e10s enabled and "security.sandbox.content.level" to "0" resolves the problem.
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Joe McCabe from comment #10)
> (In reply to Paul Adenot (:padenot) from comment #4)
> > Can someone try to re-enable e10s, and go to about:config, set
> > "security.sandbox.content.level" to "0", restart the browser, and try again ?
>
> Confirmed that e10s enabled and "security.sandbox.content.level" to "0"
> resolves the problem.
Thanks. I'll be able to get 10.13 installed in a few days and will work on this.
Assignee | ||
Comment 12•7 years ago
|
||
Adding the com.apple.audio.AudioComponentRegistrar permission in the content sandbox allows YouTube sound to work on 10.13 for the videos I tested. I need to do a bit more testing and will then get this landed on Nightly. In the meantime, I triggered a Nightly build (both debug and non-debug) on treeherder which should be available within a few hours:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a303dace3e76eda5f0c649207db6cd8ad7ec84ac
We also have a problem with Netflix playback on 10.13 and this change resolves that problem too. I'll close 1378244 as a dupe of this bug.
The change needs to be in the content sandbox, not the plugin sandbox, because (confirmed with :cpearce) the content process is what plays the audio.
Assignee | ||
Updated•7 years ago
|
Summary: [10.13] No audio playback on YouTube (macOS High Sierra 10.13 Beta) → [10.13] No audio playback on YouTube, no audio/video on Netflix (macOS High Sierra 10.13 Beta)
Assignee | ||
Updated•7 years ago
|
Component: Audio/Video: cubeb → Security: Process Sandboxing
Comment 14•7 years ago
|
||
How do I disable e10's? Can somebody please help? Also, how do I set "security.sandbox.content.level" to "0" as stated in one of the comments? People always mention this kind of stuff, without telling me how to actually do it! I don't know how to disable e10s or multip processes? How do I do it?
25$ bounty avalible
30 minute time limit
Comment 15•7 years ago
|
||
Whats a firefox profile?
What's a release channel?
People can you please be specific when talking about things!
Comment 16•7 years ago
|
||
(In reply to Paul Adenot (:padenot) from comment #4)
> Can someone try to re-enable e10s, and go to about:config, set
> "security.sandbox.content.level" to "0", restart the browser, and try again ?
Where is about:config?
Please be specific!
What buttons do I click. Do I click the menu first? Why isn't anybody actually speaking human language?
Comment 17•7 years ago
|
||
Where does it say e10s? I already looked through the menus and options! WHERE DOES IT SAY E10S IM NOT AN ADULT DEVELOPER, IM JUST A USER!!
Comment 18•7 years ago
|
||
(In reply to harrisontao01 from comment #14)
> How do I disable e10's? Can somebody please help? […]
I’m not using High Sierra myself, but from reading the comments I got this much.
You won’t want to disable e10s (that’s Mozilla’s short name for Electrolysis, a big new improvement to Firefox).
If you’re not seeing ‘Enable multi-process Nightly’ in your Firefox ▸ Preferences ▸ General screen then there’s nothing to do, see this screenshot for what you would enable (it’s the first option): https://wiki.mozilla.org/images/d/da/E10s-toggle-in-preferences.png
Then in the address bar, type about:config, you’ll be warned about making changes, read that and accept the risk.
In the about:config, search for “security.sandbox.content.level”.
Double-click anywhere on the “security.sandbox.content.level” preference, in the window that pops up, change the value to “0”.
And as a brief aside, you really would have found this a lot faster (and without needing to offer any financial incentive) had you searched for “firefox about config”: https://www.google.co.uk/search?q=firefox+about+config
Assignee | ||
Updated•7 years ago
|
Whiteboard: sb+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8884091 -
Flags: review?(agaynor)
Assignee | ||
Comment 20•7 years ago
|
||
mozreview-review |
Comment on attachment 8884091 [details]
Bug 1376163 - [10.13] No audio playback on YouTube, no audio/video on Netflix (macOS High Sierra 10.13 Beta).
https://reviewboard.mozilla.org/r/155030/#review160086
::: security/sandbox/mac/Sandbox.mm:165
(Diff revision 1)
> + params.push_back("MAC_OS_MINOR_13");
> + params.push_back(OSXVersion::OSXVersionMinor() == 13 ? "TRUE" : "FALSE");
I need to fix this to apply to 10.13 and newer OS versions.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 22•7 years ago
|
||
(In reply to Haik Aftandilian [:haik] from comment #20)
> I need to fix this to apply to 10.13 and newer OS versions.
Fixed.
Comment 23•7 years ago
|
||
mozreview-review |
Comment on attachment 8884091 [details]
Bug 1376163 - [10.13] No audio playback on YouTube, no audio/video on Netflix (macOS High Sierra 10.13 Beta).
https://reviewboard.mozilla.org/r/155030/#review160264
Attachment #8884091 -
Flags: review?(agaynor) → review+
Comment 24•7 years ago
|
||
Pushed by haftandilian@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55f82c8f561f
[10.13] No audio playback on YouTube, no audio/video on Netflix (macOS High Sierra 10.13 Beta). r=Alex_Gaynor
Comment 25•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 26•7 years ago
|
||
Verified fixed using Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:56.0) Gecko/20100101 Firefox/56.0 ID:20170710100238 CSet: a418121d46250f91728b86d9eea331029c264c30. I am using B2 build.
I verified by playing various videos on both you tube and Netflix and encountered no issues with audio not playing.
Status: RESOLVED → VERIFIED
Assignee | ||
Updated•7 years ago
|
status-firefox54:
--- → affected
status-firefox55:
--- → affected
Assignee | ||
Comment 27•7 years ago
|
||
Assignee | ||
Comment 28•7 years ago
|
||
This patch for 54 is slightly different so requesting additional review.
Attachment #8884925 -
Flags: review?(agaynor)
Assignee | ||
Comment 29•7 years ago
|
||
I'm debugging an issue on build 54 with the fix. Once that is resolved, I'll request uplift.
Updated•7 years ago
|
Attachment #8884925 -
Flags: review?(agaynor) → review+
Assignee | ||
Comment 30•7 years ago
|
||
Comment on attachment 8884920 [details] [diff] [review]
Beta/55 patch: Allow access to com.apple.audio.AudioComponentRegistrar in the content sandbox
Approval Request Comment
[Feature/Bug causing the regression]:
None. The problem only occurs on macOS 10.13 "High Sierra" beta versions.
[User impact if declined]:
On beta versions of macOS 10.13 High Sierra, Firefox fails to play video from Netflix and other streaming audio/video sites.
[Is this code covered by automated tests?]:
No
[Has the fix been verified in Nightly?]:
Yes
[Needs manual test from QE? If yes, steps to reproduce]:
Yes
[List of other uplifts needed for the feature/fix]:
None
[Is the change risky?]:
No
[Why is the change risky/not risky?]:
The new Sandboxing permission is only applied on macOS 10.13 (which is in Beta) and shouldn't impact Firefox shipping on shipping versions of macOS.
[String changes made/needed]:
None
Attachment #8884920 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•7 years ago
|
Blocks: highsierra
Comment 31•7 years ago
|
||
Comment on attachment 8884920 [details] [diff] [review]
Beta/55 patch: Allow access to com.apple.audio.AudioComponentRegistrar in the content sandbox
sandbox fix for newest macos, beta55+
Attachment #8884920 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 32•7 years ago
|
||
bugherder uplift |
Assignee | ||
Comment 33•7 years ago
|
||
I haven't been able to verify the 54/Release fix on 10.13 due to bug 1380070. However, we know we'll need to allow AudioComponentRegistrar on 10.13 and the fix does not cause any problems on 10.12. It's also extremely low risk. Given all that, I'm requesting uplift for 54 now.
Updated•7 years ago
|
Flags: qe-verify+
Assignee | ||
Comment 34•7 years ago
|
||
Comment on attachment 8884925 [details] [diff] [review]
Release/54 patch: Allow access to com.apple.audio.AudioComponentRegistrar in the content sandbox
Approval Request Comment
[Feature/Bug causing the regression]:
None. The problem only occurs on macOS 10.13 "High Sierra" beta versions.
[User impact if declined]:
On beta versions of macOS 10.13 High Sierra, Firefox fails to play video from Netflix and other streaming audio/video sites.
[Is this code covered by automated tests?]:
No
[Has the fix been verified in Nightly?]:
Yes
[Needs manual test from QE? If yes, steps to reproduce]:
Other bugs (1380070) are blocking validation.
[List of other uplifts needed for the feature/fix]:
Bug 1380070 needs to be resolved.
[Is the change risky?]:
No
[Why is the change risky/not risky?]:
The new Sandboxing permission is only applied on macOS 10.13 (which is in Beta) and shouldn't impact Firefox shipping on shipping versions of macOS.
[String changes made/needed]:
No
Attachment #8884925 -
Flags: approval-mozilla-release?
Assignee | ||
Comment 35•7 years ago
|
||
I've confirmed the fix works with build 54 on 10.13 beta 3.
Comment 36•7 years ago
|
||
We're about to merge 55 to release next monday, and ship the week after, so there won't be a need to rev 54 for this.
Comment 37•7 years ago
|
||
Comment on attachment 8884925 [details] [diff] [review]
Release/54 patch: Allow access to com.apple.audio.AudioComponentRegistrar in the content sandbox
we'll ship this fix in 55 in a couple of weeks.
Attachment #8884925 -
Flags: approval-mozilla-release? → approval-mozilla-release-
Updated•7 years ago
|
Comment 38•7 years ago
|
||
Verified fixed on macOS High Sierra Developer Beta 7 for Firefox 55.0.2 and Firefox 56.0b5.
Updated•7 years ago
|
Flags: qe-verify+
Comment 39•7 years ago
|
||
Haik, is this something we should consider uplifting to ESR52? We're getting some reports of video playback issues on 10.13 with that release.
Flags: needinfo?(haftandilian)
Assignee | ||
Comment 40•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #39)
> Haik, is this something we should consider uplifting to ESR52? We're getting
> some reports of video playback issues on 10.13 with that release.
Yes, this is going to be needed in ESR52 for High Sierra compatibility. Bug 1392988 is probably also going to be needed.
I'll test on 52 and get patches posted.
Flags: needinfo?(haftandilian)
Updated•7 years ago
|
status-firefox-esr52:
--- → affected
tracking-firefox-esr52:
--- → ?
Assignee | ||
Comment 41•7 years ago
|
||
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
Causes crashes on popular sites with the newly released version of mac OS -- High Siera 10.13.
High visibility bug per: https://bugzilla.mozilla.org/show_bug.cgi?id=1404481#c3
User impact if declined:
Netflix and YouTube and other video/audio sites cause content process crashes.
Fix Landed on Version:
The fix is already in 57/56.
Risk to taking this patch (and alternatives if risky):
Very low risk.
String or UUID changes made by this patch:
None
See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Attachment #8915446 -
Flags: review?(agaynor)
Attachment #8915446 -
Flags: approval-mozilla-esr52?
Comment 43•7 years ago
|
||
Sounds like we might want a 52.4.1 build for this.
Updated•7 years ago
|
Attachment #8915446 -
Flags: review?(agaynor) → review+
Comment 44•7 years ago
|
||
Comment on attachment 8915446 [details] [diff] [review]
ESR/52 patch: Allow access to com.apple.audio.AudioComponentRegistrar in the content sandbox
macos sandbox fix for 10.13, let's land this on esr52 now.
Attachment #8915446 -
Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Comment 45•7 years ago
|
||
bugherder uplift |
Comment 46•7 years ago
|
||
I'll leave the formal verification to Softvision when they're doing the sign-offs next week, but local testing with a CI build from ESR52 confirms that I no longer crash when playing Youtube videos :)
Comment 47•7 years ago
|
||
I managed to reproduce the bug using an older version of Nightly (2016-06-25) on macOS 10.13.
I retested using esr 52.4.2 - build 1 and the bug is not reproducing anymore. Both youtube.com and netflix.com have audio playback.
You need to log in
before you can comment on or make changes to this bug.
Description
•