Closed
Bug 1376334
Opened 7 years ago
Closed 7 years ago
Consider dispatching IMENotificationSender runnable differently (possibly off of the idle queue)
Categories
(Core :: DOM: Events, enhancement, P1)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
People
(Reporter: mstange, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Here's a speedometer profile in which we're dispatching a IMENotificationSender runnable during an async test (so it gets measured and contributes to the score): http://bit.ly/2saFDqT
Flags: needinfo?(bugs)
|
||
Comment 1•7 years ago
|
||
This is very much related to bug 1375491.
Using idle dispatch sounds wrong.
Depends on: 1375491
Flags: needinfo?(bugs) → needinfo?(masayuki)
|
|
||
Comment 2•7 years ago
|
||
We should rather run the runnable around the time we flush layout anyhow.
|
Assignee | |
Comment 3•7 years ago
|
||
I think so. If "idle" always occurred immediately after input event, my though would be wrong, though.
Flags: needinfo?(masayuki)
|
|
||
Comment 4•7 years ago
|
||
Idle may happen at any point or may not happen at all.
|
||
Comment 5•7 years ago
|
||
If this indeed negatively affects Speedometer then it should be P1.
Assignee: nobody → masayuki
Priority: -- → P1
|
|
||
Comment 6•7 years ago
|
||
bug 1375491 changed this quite a bit. This needs first some reprofiling.
|
|
Assignee | |
Comment 7•7 years ago
|
||
mstange:
Could you check if we still need to do it after fixing bug 1375491?
Flags: needinfo?(mstange)
|
|
||
Comment 8•7 years ago
|
||
So this was slow because of the reflow.
bug 1375491 should have moved the flush to happen in better place.
Marking fixed, but please reopen if this is still an issue.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(mstange)
You need to log in
before you can comment on or make changes to this bug.
Description
•