Closed
Bug 1376515
Opened 7 years ago
Closed 7 years ago
Consolidate identical rules for win/linux/osx downloads indicator into the shared stylesheet
Categories
(Firefox :: Downloads Panel, enhancement, P1)
Firefox
Downloads Panel
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: sfoster, Assigned: sfoster)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-animation])
Attachments
(1 file)
The indicator.css stylesheet for each of windows / osx / linux has rules which are now identical and can be removed and shared from the indicator.inc.css
|
||
Updated•7 years ago
|
Flags: qe-verify?
Priority: -- → P2
| Comment hidden (mozreview-request) |
|
|
||
Updated•7 years ago
|
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Iteration: --- → 56.2 - Jul 10
Priority: P2 → P1
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8881527 [details]
Bug 1376515 - Move shared download indicator rules to indicator.inc.css.
https://reviewboard.mozilla.org/r/152682/#review157972
Thanks!
::: browser/themes/linux/downloads/indicator.css:7
(Diff revision 2)
> * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>
> %include ../../shared/downloads/indicator.inc.css
>
> -/*** Status and progress indicator ***/
>
nit: newline at end of file, but no extra empty lines
::: browser/themes/shared/downloads/indicator.inc.css:20
(Diff revision 2)
> +#downloads-indicator-anchor {
> + min-width: 16px;
> + min-height: 16px;
> +}
> +
> +#downloads-button > #downloads-indicator-anchor > #downloads-indicator-icon {
Just #downloads-indicator-icon.
Attachment #8881527 -
Flags: review?(paolo.mozmail) → review+
| Comment hidden (mozreview-request) |
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e421b9a0b337
Move shared download indicator rules to indicator.inc.css. r=Paolo
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
|
||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•