Closed
Bug 1376796
Opened 7 years ago
Closed 7 years ago
Label the nsCaret::CaretBlinkCallback_timer
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: billm, Assigned: bevis)
References
Details
Attachments
(1 file)
(deleted),
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
I think we'll need to label this with a TabGroup. I see that nsCaret has a pointer to a pres shell, so maybe we could use that to find a document to label it with.
Since this is a timer, we can use SetTarget and pass document->EventTargetFor(...).
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
Hey Cameron,
May I have your review for this change?
Thanks!
Comment 2•7 years ago
|
||
Comment on attachment 8893222 [details] [diff] [review]
(v1) Patch: Label the nsCaret::CaretBlinkCallback_timer.
Review of attachment 8893222 [details] [diff] [review]:
-----------------------------------------------------------------
Re-balancing some of my review load. :-)
Attachment #8893222 -
Flags: review?(cam) → review?(xidorn+moz)
Updated•7 years ago
|
Attachment #8893222 -
Flags: review?(xidorn+moz) → review+
Assignee | ||
Comment 3•7 years ago
|
||
treeherder result looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98adfea224e74c6e4a70727838c76582ef07701a
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3367ef7283a1
Label the nsCaret::CaretBlinkCallback_timer. r=heycam
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/321fecf23a68
Label the nsCaret::CaretBlinkCallback_timer. r=xidorn
Comment 6•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•