Closed
Bug 1376981
Opened 7 years ago
Closed 7 years ago
Label nsBindingManager::DoProcessAttachedQueue runnable
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This runnable seems pretty easy to label since there's a document readily available.
Attachment #8882004 -
Flags: review?(bugs)
Comment 1•7 years ago
|
||
Comment on attachment 8882004 [details] [diff] [review]
patch
> nsBindingManager::PostProcessAttachedQueueEvent()
> {
>+ MOZ_ASSERT(NS_IsMainThread());
> mProcessAttachedQueueEvent =
> NewRunnableMethod("nsBindingManager::DoProcessAttachedQueue",
> this, &nsBindingManager::DoProcessAttachedQueue);
>- nsresult rv = NS_DispatchToCurrentThread(mProcessAttachedQueueEvent);
>+ nsresult rv = mDocument->EventTargetFor(TaskCategory::Other)->Dispatch(do_AddRef(mProcessAttachedQueueEvent));
> if (NS_SUCCEEDED(rv) && mDocument) {
So here we do null check for mDocument. Silly to first use mDocument and then null check it.
I think you could add a null check early in the method and just return then and remove null check from the if (...mDocument)
With that, r+
Attachment #8882004 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → wmccloskey
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ca3d02cd72
Label nsBindingManager::PostProcessAttachedQueueEvent (r=smaug)
Comment 3•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•