Closed Bug 1377224 Opened 7 years ago Closed 7 years ago

Scrolling after resize makes address bar inaccessible

Categories

(Firefox for Android Graveyard :: Toolbar, defect)

56 Branch
defect
Not set
normal

Tracking

(firefox54 unaffected, firefox55 verified, firefox56 verified)

VERIFIED FIXED
Firefox 56
Tracking Status
firefox54 --- unaffected
firefox55 --- verified
firefox56 --- verified

People

(Reporter: agashlin, Assigned: rbarker)

References

Details

Attachments

(2 files)

Attached file Demonstration of scroll behavior (deleted) —
Steps to reproduce: 1. With Firefox in portrait mode, load the attached document 2. Rotate the device to switch to landscape 3. Scroll down (swipe up), then up (swipe down) 4. Location bar does not move, but scroll end animation indicates that the whole screen is the scrolling page, and tapping on the scrollbar does nothing. This persists after switching back to portrait. Demonstrated on a Google Pixel here: http://gashlin.net/files/20170629_124454.mp4 This does not seem to occur in the current release of Firefox for Android, instead when scrolling down the address bar scrolls offscreen as expected and returns when scrolling back up, so it appears to be a regression.
Randall, can you take a look? Dynamic toolbar is all yours now! :)
Flags: needinfo?(rbarker)
Assignee: nobody → rbarker
Flags: needinfo?(rbarker)
Comment on attachment 8882355 [details] Bug 1377224 - Ensure the real toolbar is visible when the page is too small to scroll https://reviewboard.mozilla.org/r/153454/#review158622 (mostly a rubberstamp). please request uplift if this affects 55.
Attachment #8882355 - Flags: review?(bugmail) → review+
Pushed by rbarker@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/116acc87ff33 Ensure the real toolbar is visible when the page is too small to scroll r=kats
Comment on attachment 8882355 [details] Bug 1377224 - Ensure the real toolbar is visible when the page is too small to scroll Approval Request Comment [Feature/Bug causing the regression]: Dynamic Toolbar v3 [User impact if declined]: When viewing images, it is possible for the toolbar to become unresponsive. [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: add a check to ensure the real toolbar is visible when the static toolbar is visible. [String changes made/needed]: none
Attachment #8882355 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment on attachment 8882355 [details] Bug 1377224 - Ensure the real toolbar is visible when the page is too small to scroll fix a regression with fennec's toolbar, beta55+
Attachment #8882355 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Not too happy with "no automated tests, no verification, no manual testing", but I guess the patch is small enough.
Just wanted to add that I checked this again on Nightly and it seems to be fixed, thanks!
I was not able to reproduce the issue on neither Beta or Nightly so I'll mark this as fixed, based also on Adam's comment. Devices: -HTC Nexus 9 (Android 7.1.1) -Samsung Galaxy Note 4 (Android 5.0.1) Build: Beta 55.0b7 (2017-7-7)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: