Closed Bug 1377285 Opened 7 years ago Closed 7 years ago

[a11y] Big blue buttons on all tabs must have a better focused state styling.

Categories

(Firefox :: General, defect, P3)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified
firefox58 --- verified

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: access, Whiteboard: [photon-onboarding])

Attachments

(5 files)

1377285 button focus styling.
(deleted), patch
mossop
: review+
verdi
: ui-review+
lizzard
: approval-mozilla-beta-
Details | Diff | Splinter Review
Before
(deleted), image/png
Details
Before High Contrast
(deleted), image/png
Details
After
(deleted), image/png
Details
After High Contrast
(deleted), image/png
Details
Right now only the text has a faintly dotted outline when the button is in focus. We should have something more pronounced, similar to the main Firefox UI, or about:preferences focused button layout.
according to the discussion with Photon onboarding PM/UX, change to P3
Priority: -- → P3
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Attached patch 1377285 button focus styling. (deleted) — — Splinter Review
Added button focus styling , it also works well in high contrast.
Attachment #8889548 - Flags: ui-review?(mverdi)
Attachment #8889548 - Flags: review?(dtownsend)
Attached image Before (deleted) —
Attached image Before High Contrast (deleted) —
Attached image After (deleted) —
Attached image After High Contrast (deleted) —
Comment on attachment 8889548 [details] [diff] [review] 1377285 button focus styling. That's awesome - thank you!
Attachment #8889548 - Flags: ui-review?(mverdi) → ui-review+
Attachment #8889548 - Flags: review?(dtownsend) → review+
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ae7f1e8f2b35 better focus styling for onboarding-tour action buttons. r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ae7f1e8f2b35
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this bug with nightly 56.0a1 (2017-06-29) on Linux Mint (64 Bit). The bug's fix is now verified on Latest Nightly 56.0a1 Build ID 20170803100352 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170802]
I can verify this issue has been fixed
Status: RESOLVED → VERIFIED
Comment on attachment 8889548 [details] [diff] [review] 1377285 button focus styling. This is one of several bugs that make onboarding accessible to keyboard and screen reader users. [Feature/Bug causing the regression]: None [User impact if declined]: Users who use accessibility services or keyboard would not be able to use onboarding. [Is this code covered by automated tests?]: No, css changes only [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Onboarding action buttons should have a focus styling that is well visible - blue outline. [List of other uplifts needed for the feature/fix]: not for this bug, but all onboarding accessibility bugs are listed in bug 1377300 [Is the change risky?]: No [Why is the change risky/not risky?]: Only affects users that use keyboard [String changes made/needed]: None
Attachment #8889548 - Flags: approval-mozilla-beta?
It looks like this fix landed on 56 already back in July.
Attachment #8889548 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
I can confirm the styling is as specified in comment 12. I verified using Fx 56.0b8, on Windows 10 x64, mac OS X 10.12.6 and Ubuntu 14.04 LTS.
status-firefox56: fixed → verified
Flags: qe-verify+
QA Contact: jwilliams
I have verified that this issue works as expected per comment 12 on Win 10 x64, Win 7 x86, Mac 10.13, & Ubuntu 16.04 x32 with Firefox 58.
status-firefox58: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: