In bug 1355048, mediaconduit_unittests.cpp was removed. It can't compile as it is missing pure virtual interface, it also couldn't have worked in this state. It would be nice to have proper unit testing on this module. so let's track re-adding it here.

:jya, I have a patch in progress for this which I'm hoping to get up for review next week.

Dan, would be nice to coordinate things here then, because we're going to clash :)

(In reply to Jean-Yves Avenard [:jya] from comment #2) > Dan, would be nice to coordinate things here then, because we're going to > clash :) I've done the minimum necessary to get them running again. If you've done more than that, it probably makes the most sense for me to stop work and you to land your patches instead. Let me know :)

I don't see how it can compile with your current changes in bug 1328169, it's missing implementation of one RenderVideoFrame that is pure virtual (though it's one I've removed in bug 1355048 because it's unused)

(In reply to Jean-Yves Avenard [:jya] from comment #4) > I don't see how it can compile with your current changes in bug 1328169, > it's missing implementation of one RenderVideoFrame that is pure virtual > (though it's one I've removed in bug 1355048 because it's unused) The patch on that bug is old, I was in the process of updating it, but I'm happy to stop if I'm duplicating work.

I'll remove the related patch of bug 1355048, you can continue whenever you wish to.