I see in url-classifier code that preference browser.safebrowsing.debug (in log(...))is read a lot of time, should cache it somewhere, listen to value change, and reuse

MozReview-Commit-ID: 1yWe7wB0ARl

Wip patch, I would like to wait for landing bug 1297614 first

I would like to do in this bug because, in some profiles, reading pref may take time https://perf-html.io/public/cfe5c76c2f54845efece5f125c6c841c034e3a9c/calltree/?callTreeFilters=prefixjs-DUdDUiDXjDXk&hiddenThreads=&implementation=js&range=2.4996_2.6945&thread=0&threadOrder=0-2-3-1

Comment on attachment 8884143 [details] Bug 1377559 - Should store value of preference browser.safebrowsing.debug to reuse https://reviewboard.mozilla.org/r/155054/#review160370 ::: toolkit/components/url-classifier/SafeBrowsing.jsm:13 (Diff revision 1) > const Ci = Components.interfaces; > const Cu = Components.utils; > > Cu.import("resource://gre/modules/Services.jsm"); > > +let loggingEnabled = false; Let's add a constant here, just like in listmanager.js ::: toolkit/components/url-classifier/content/listmanager.js:23 (Diff revision 1) > // Lower and upper limits on the server-provided polling frequency > const minDelayMs = 5 * 60 * 1000; > const maxDelayMs = 24 * 60 * 60 * 1000; > const defaultUpdateIntervalMs = 30 * 60 * 1000; > > +const PREF_LOGGING_ENABLED = "browser.safebrowsing.debug"; The `loggingEnabled` variable makes sense to me, but I think the constant should be `PREF_DEBUG_ENABLED` to avoid confusion. ::: toolkit/components/url-classifier/nsUrlClassifierHashCompleter.js:18 (Diff revision 1) > const COMPLETE_LENGTH = 32; > const PARTIAL_LENGTH = 4; > > // Upper limit on the server response minimumWaitDuration > const MIN_WAIT_DURATION_MAX_VALUE = 24 * 60 * 60 * 1000; > +const PREF_LOGGING_ENABLED = "browser.safebrowsing.debug"; `PREF_DEBUG_ENABLED`

Comment on attachment 8884143 [details] Bug 1377559 - Should store value of preference browser.safebrowsing.debug to reuse https://reviewboard.mozilla.org/r/155054/#review160606 Thanks you for your review

Comment on attachment 8884143 [details] Bug 1377559 - Should store value of preference browser.safebrowsing.debug to reuse https://reviewboard.mozilla.org/r/155054/#review160812 ::: toolkit/components/url-classifier/SafeBrowsing.jsm:196 (Diff revision 2) > // skip nextupdatetime and lastupdatetime > if (aData.indexOf("lastupdatetime") >= 0 || aData.indexOf("nextupdatetime") >= 0) { > return; > } > + > + if (aData == PREF_DEBUG_ENABLED") { This stray `"` is causing a syntax error.

Comment on attachment 8884143 [details] Bug 1377559 - Should store value of preference browser.safebrowsing.debug to reuse https://reviewboard.mozilla.org/r/155054/#review161366

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f95be8a71102 Should store value of preference browser.safebrowsing.debug to reuse r=francois