Closed
Bug 1377607
Opened 7 years ago
Closed 7 years ago
HasStableTSC compares signed and unsigned and causes an error
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
> /home/worker/workspace/build/src/mozglue/misc/TimeStamp_windows.cpp: In function 'bool mozilla::HasStableTSC()':
> /home/worker/workspace/build/src/mozglue/misc/TimeStamp_windows.cpp:481:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
> if (regs[0] < 0x80000007) {
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8882761 -
Flags: review?(nfroyd)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8882761 [details]
Bug 1377607 Cast int to unsigned to silence an error about signed vs unsigned comparisons
https://reviewboard.mozilla.org/r/153868/#review159178
Attachment #8882761 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2c9baffd57b
Cast int to unsigned to silence an error about signed vs unsigned comparisons r=froydnj
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•