Closed Bug 1377767 Opened 7 years ago Closed 7 years ago

TelemetrySession.jsm uses non-existing API Services.tm.mainThread.idleDispatch

Categories

(Toolkit :: Telemetry, enhancement, P3)

Product:
Toolkit
Component:
Telemetry
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: ato, Assigned: erahm)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1377767 - Fix idle dispatch call to gather memory in Telemetry;
(deleted), text/x-review-board-request
erahm
: review+
Details
This is occasionally logged when running Firefox: > JavaScript error: resource://gre/modules/TelemetrySession.jsm, line 1979: TypeError: Services.tm.mainThread.idleDispatch is not a function The Services.tm.mainThread.idleDispatch API was renamed in https://bugzilla.mozilla.org/show_bug.cgi?id=1368072 to Services.tm.idleDispatchToMainThread.
Depends on: 1340134
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment on attachment 8882896 [details] Bug 1377767 - Fix idle dispatch call to gather memory in Telemetry; https://reviewboard.mozilla.org/r/153922/#review159148 Thanks for catching this!
Attachment #8882896 - Flags: review?(erahm) → review+
Priority: -- → P3
I see this a lot lately in our test results for failing tests. Given that Andreas is out the next days and the patch got review+ lets get this landed.
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0650bad015bc Fix idle dispatch call to gather memory in Telemetry; r=erahm
https://hg.mozilla.org/mozilla-central/rev/0650bad015bc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Attached patch Always update cached ghost window count (obsolete) (deleted) — — Splinter Review
Currently the cached count is only updated if a table was passed in to keep track of the window IDs. This changes the behavior to always update the count regardless of whether a table is passed in. MozReview-Commit-ID: EkfzLemVJyV
Attachment #8891104 - Flags: review?(continuation)
Assignee: ato → erahm
Comment on attachment 8891104 [details] [diff] [review] Always update cached ghost window count Sorry wrong bug number.
Attachment #8891104 - Attachment is obsolete: true
Attachment #8891104 - Flags: review?(continuation)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: