Closed
Bug 1377876
Opened 7 years ago
Closed 7 years ago
Don't run test_crash.py for code-coverage builds because crash reporter is disabled
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: sparky, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This bug is for disabling the marionette unit tests in the manifest 'unit/unit-tests.ini' when they run on linux64-ccov.
The cause of this problem is a slow build that seems to delay the creation of the minidump files that many of these tests rely on (like 'asan').
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•7 years ago
|
||
Here's a test run with it passing on linux64-ccov: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49d77df94a0ad11d1f84eaa5bb6ac2c450d5c2f
And here's a test run with linux64 which shows that mozinfo.json contains the coverage field now by default and is set to false: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d3cb7ed3eedb3ec9b30fc415e549166bf3fe196
There is more work that needs to be done to modify how the mozinfo is used in other test suites and this will be done in a follow-up bug because linux64-jsdcov needs a new variable like 'MOZ_CODE_COVERAGE' to be able to have it set by default instead of when the '*/runtests.py' files are being run.
Assignee | ||
Comment 3•7 years ago
|
||
Greg, I thought that we (including Kyle) agreed on to only disable this specific test file for now.
Flags: needinfo?(gmierz2)
Reporter | ||
Comment 4•7 years ago
|
||
Comment hidden (mozreview-request) |
Reporter | ||
Comment 6•7 years ago
|
||
I misunderstood, I'm sorry about that. I've started another test (just in case) and submitted a new patch for review. I've also left a small formatting change in the 'unit-tests.ini' file I previously had modified.
Flags: needinfo?(gmierz2)
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8883053 [details]
Bug 1377876 - Disable 'test_crash.py' when running on linux64-ccov.
https://reviewboard.mozilla.org/r/154014/#review159224
I'm not a valid reviewer of build config changes. But this looks simple enough and is doing what it should do. As best the patch might have been splitted into two different commits (one per component). But to stop this perma failure I will get it landed now. Thanks for getting this implemented!
Attachment #8883053 -
Flags: review?(hskupin) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44222e50fcf1
Disable 'test_crash.py' when running on linux64-ccov. r=whimboo
Assignee | ||
Updated•7 years ago
|
Comment 9•7 years ago
|
||
bugherder |
Assignee | ||
Comment 10•7 years ago
|
||
Marking as disabled until the underlying bug has been fixed.
Reporter | ||
Comment 11•7 years ago
|
||
Not a problem :whimboo! And thanks for your comment, I'll keep that in mind for my next patches.
Assignee | ||
Comment 12•7 years ago
|
||
As being informed on bug 1376795 the code coverage builds do not have the crash reporter turned on! As such the unit test should not be run because it relies on its existence.
With my patch on bug 1381403 we now dynamically skip each test if the crash reporter is not available in the build.
Assignee: nobody → hskupin
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: Disable marionette unit tests in 'unit/unit-tests.ini' on linux64-ccov. → Don't run test_crash.py for code-coverage builds because crash reporter is disabled
Target Milestone: --- → mozilla56
Comment 13•7 years ago
|
||
We have enabled the crash reporter in the code coverage builds now, we should make sure this test is being run.
Flags: needinfo?(mcastelluccio)
Flags: needinfo?(jmaher)
Flags: needinfo?(gmierz2)
Comment 14•7 years ago
|
||
it appears we already run this- the change to skip for 'coverage' doesn't exist, I believe bug 1381403 makes this work more reliably.
Flags: needinfo?(mcastelluccio)
Flags: needinfo?(jmaher)
Flags: needinfo?(gmierz2)
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•