Closed
Bug 1378246
Opened 7 years ago
Closed 7 years ago
Modifications made during bookmark deletions are counted incorrectly
Categories
(Firefox for Android Graveyard :: Data Providers, defect)
Firefox for Android Graveyard
Data Providers
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: Grisha, Assigned: Grisha)
References
Details
Attachments
(1 file)
This is a regression from the "deleting folders" part of the full bookmark management work done in one of the children of Bug 1329127.
If a non-folder bookmark is removed, notifyChange never fires. This has bad implications for sync, and also manifests in regressions in our home panels. For example, unpinning a site in Activity Stream is not reflected in the UI.
|
Assignee | |
Comment 1•7 years ago
|
||
Actually, the issue here seems larger in scope. For most cases, number of modified records during bookmark deletions is counted incorrectly. In a specific case of activity stream pins, we under-count and think that nothing was modified, and thus notifyChange doesn't fire. In a broader case of non-pin deletions, we seem to be over-counting instead due to an error in `getBookmarkDescendantGUIDs`.
Tests make wrong assumptions about what those counts _should_ be, and are thus ensure incorrect behaviour.
Summary: Deletions of non-folder bookmarks never trigger 'notifyChange' → Modifications made during bookmark deletions are counted incorrectly
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8883655 [details]
Bug 1378246 - Ensure that we correctly fire 'notifyChanged' during bookmark deletions
https://reviewboard.mozilla.org/r/154568/#review160776
Attachment #8883655 -
Flags: review?(topwu.tw) → review+
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da503e89be28
Ensure that we correctly fire 'notifyChanged' during bookmark deletions r=jwu
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•