Closed
Bug 1378285
Opened 7 years ago
Closed 7 years ago
Reftest to verify the last frame of bipbop.mp4
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: bechen, Assigned: bechen)
References
Details
Attachments
(2 files, 1 obsolete file)
I want to add a reftest to verify the last frame of bipbop.mp3.
The testcase flow:
1. play the bipbop.mp4
2. listen the onended event
3. check the screen
Since we are checking the last frame, I think we can keep the preference skipToNextKeyFrame TRUE.
Updated•7 years ago
|
Priority: -- → P3
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8885589 [details]
Bug 1378285 - Last frame reftest for bipbop.mp4 .
https://reviewboard.mozilla.org/r/156436/#review161986
::: dom/media/test/reftest/bipbop_300_215kbps.mp4.lastframe.html:9
(Diff revision 2)
> +<script type="text/javascript">
> +function doTest() {
> + var video = document.getElementById("v1");
> + video.src = "../bipbop_300_215kbps.mp4";
> + video.play();
> + video.addEventListener("ended", function() {
nit : modify this listener as one-time-usage.
```
video.addEventListener("ended", function() {
// do something
}, {once: true});
```
::: dom/media/test/reftest/bipbop_300_215kbps.mp4.lastframe.html:10
(Diff revision 2)
> +function doTest() {
> + var video = document.getElementById("v1");
> + video.src = "../bipbop_300_215kbps.mp4";
> + video.play();
> + video.addEventListener("ended", function() {
> + video.seenEnded = true;
why you need this?
Attachment #8885589 -
Flags: review?(alwu) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8886079 [details]
Bug 1378285 - Modify the generateREF.html to resolve the output limit of console.
https://reviewboard.mozilla.org/r/156884/#review161988
Attachment #8886079 -
Flags: review?(alwu) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8886079 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8886908 [details]
Bug 1378285 - Modify the generateREF.html to resolve the output limit of console.
https://reviewboard.mozilla.org/r/157634/#review162754
Attachment #8886908 -
Flags: review?(alwu) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/90497fbb54a6
Last frame reftest for bipbop.mp4 . r=alwu
https://hg.mozilla.org/integration/autoland/rev/820a85e09ac3
Modify the generateREF.html to resolve the output limit of console. r=alwu
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/90497fbb54a6
https://hg.mozilla.org/mozilla-central/rev/820a85e09ac3
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•