Closed
Bug 137857
Opened 23 years ago
Closed 23 years ago
Move HandleNumbers from nsBidiPresUtils to nsBidiUtils
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ftang
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
This is part of the groundwork for bug 99823. HandleNumbers should really have
already been moved to nsBidiUtils in bug 120818, but I missed it.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
ftang, can you review?
|
||
Comment 3•23 years ago
|
||
why we want to move it? what is the benefit of moving it ?
|
|
||
Comment 4•23 years ago
|
||
what will it block if we don't move it ?
|
|
Assignee | |
Comment 5•23 years ago
|
||
Moving this enables us to convert Arabic numerals to Indic and vice versa
without needing an nsBidiPresUtils object. It blocks the changes to
nsTextTransformer.cpp in attachment 77103 [details] [diff] [review] (in bug 99823) which I will shortly be
attaching to bug 138097 as a separate attachment.
|
|
||
Comment 6•23 years ago
|
||
Comment on attachment 79538 [details] [diff] [review]
Patch
r=ftang looks like straight forward code moving
Attachment #79538 -
Flags: review+
|
||
Comment 7•23 years ago
|
||
Comment on attachment 79538 [details] [diff] [review]
Patch
sr=attinasi
Attachment #79538 -
Flags: superreview+
|
|
Assignee | |
Comment 8•23 years ago
|
||
Fix checked in.
|
|
Assignee | |
Comment 9•23 years ago
|
||
Really marking FIXED this time.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in
before you can comment on or make changes to this bug.
Description
•