Ethan Lin[:ethlin] Reporter
	Description • 7 years ago

Currently we haven't converted nsDisplayBlendMode, so the blend mode may be wrong[1]. I'll add CreateWebRenderCommands for nsDisplayBlendMode and nsDisplayClearBackground in this bug.


[1] https://dxr.mozilla.org/mozilla-central/source/gfx/layers/wr/StackingContextHelper.cpp?q=%22%2F%2F+TODO%3A+set+correct+blend+mode.&redirect_type=single#40

	Morris Tseng [:mtseng] [:Morris] (Inactive) Assignee
	Comment 1 • 7 years ago

I have a patch for nsDisplayBlendMode. But the result is right only if the html is inside another iframe. I suspect this might related to some stacking context problem in webrender. I'll investigate this.

	Morris Tseng [:mtseng] [:Morris] (Inactive) Assignee
	Comment 2 • 7 years ago

I'll focus on nsDisplayBlendMode and nsDisplayBlendContainer in this bug. nsDisplayClearBackground should be handled by another bug.

	Morris Tseng [:mtseng] [:Morris] (Inactive) Assignee
	Comment 3 • 7 years ago

Steal bug from Ethan.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8892344 [details]
Bug 1378606 - Support mix-blend-mode in layers-free mode.

https://reviewboard.mozilla.org/r/163312/#review168742

::: layout/painting/nsDisplayList.cpp:6331
(Diff revision 1)
> +  nsRect itemBounds = mList.GetClippedBoundsWithRespectToASR(aDisplayListBuilder, mActiveScrolledRoot);
> +  nsRect childrenVisible = GetVisibleRectForChildren();
> +  nsRect visibleRect = itemBounds.Intersect(childrenVisible);
> +  float appUnitsPerDevPixel = mFrame->PresContext()->AppUnitsPerDevPixel();
> +  LayerRect bounds = ViewAs<LayerPixel>(LayoutDeviceRect::FromAppUnits(visibleRect, appUnitsPerDevPixel),
> +                                        PixelCastJustification::WebRenderHasUnitResolution);
> +  LayerPoint origin = bounds.TopLeft();

This stuff is getting duplicated quite a bit. Maybe in a followup bug we can look into pushing it inside the StackingContextHelper constructor.

	Ethan Lin[:ethlin] Reporter
	Comment 6 • 7 years ago

I will have a followup bug to refactor the StackingContextHelper constructor since I also need this for nsDisplayFilter.

	Morris Tseng [:mtseng] [:Morris] (Inactive) Assignee
	Comment 7 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e16e4cc0a056b605d54bc24c1cb67659ced01d85

	Pulsebot
	Comment 8 • 7 years ago

Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3782e1354af
Support mix-blend-mode in layers-free mode.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 9 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e3782e1354af

	Aki Sasaki (not active)
	Comment 10 • 7 years ago

https://hg.mozilla.org/projects/date/rev/e3782e1354af50aca5947a374a96a7819768be0e
Bug 1378606 - Support mix-blend-mode in layers-free mode.