Closed
Bug 1378738
Opened 7 years ago
Closed 7 years ago
Stop using sdk/window/utils in Netmonitor
Categories
(DevTools :: Netmonitor, enhancement, P1)
DevTools
Netmonitor
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file)
Add-on SDK is deprecated and we shouuldn't use it in DevTools source base:
sdk/window/utils should be removed:
http://searchfox.org/mozilla-central/rev/5e1e8d2f244bd8c210a578ff1f65c3b720efe34e/devtools/client/netmonitor/src/har/har-utils.js#26
Honza
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8883915 [details]
Bug 1378738 - Stop using sdk/window/utils in Netmonitor;
https://reviewboard.mozilla.org/r/154902/#review159884
OK. Looks like we have no choose to revert back to the original approach. LGTM for this change. Thank you Honza!
Attachment #8883915 -
Flags: review?(rchien) → review+
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db5209b501f0
Stop using sdk/window/utils in Netmonitor; r=rickychien
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Updated•7 years ago
|
Flags: qe-verify-
Priority: P3 → P1
Whiteboard: [nosdk]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•