Closed
Bug 1378814
Opened 7 years ago
Closed 7 years ago
stylo: devtools: tab crash after opening inspector tab on golem.de
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
VERIFIED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jan, Assigned: xidorn)
References
(Blocks 1 open bug, )
Details
(Keywords: nightly-community)
Crash Data
Attachments
(1 file)
Nightly 56 x64 20170706100310 @ Debian Testing (Linux 4.9.0-3-amd64, Radeon RX480) 1. fresh profile with stylo enabled 2. visit https://www.golem.de 3. Press F12 an click on the Inspector tab 4. tab crash. [@ mozalloc_abort | abort | core::option::expect_failed ] bp-03718a9c-9d98-4832-b8a6-026220170706 06.07.17 17:14 bp-1976f236-5f55-4371-b42b-d55530170706 06.07.17 17:11 bp-fa1b539d-368f-412a-9469-a3af30170706 06.07.17 17:10
Reporter | ||
Updated•7 years ago
|
Blocks: stylo-devtools
URL: https://www.golem.de
Crash Signature: [@ mozalloc_abort | abort | core::option::expect_failed ]
Has STR: --- → yes
Keywords: nightly-community
Reporter | ||
Updated•7 years ago
|
Blocks: stylo-site-issues
Updated•7 years ago
|
Crash Signature: [@ mozalloc_abort | abort | core::option::expect_failed ] → [@ mozalloc_abort | abort | core::option::expect_failed ]
[@ alloc::oom::default_oom_handler | core::option::expect_failed]
Comment 2•7 years ago
|
||
Removing the added crash signature since it seems that is another bug, Bug 1378789.
Crash Signature: [@ mozalloc_abort | abort | core::option::expect_failed ]
[@ alloc::oom::default_oom_handler | core::option::expect_failed] → [@ mozalloc_abort | abort | core::option::expect_failed ]
Assignee | ||
Comment 3•7 years ago
|
||
The panic message is
> thread '<unnamed>' panicked at 'We're not probing, so we should always get a style back'
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8884172 [details] Bug 1378814 - Don't return None in get_pseudo_style if not probing. https://reviewboard.mozilla.org/r/155094/#review160268 Arg, should've caught this on review. r=me
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8884172 [details] Bug 1378814 - Don't return None in get_pseudo_style if not probing. https://reviewboard.mozilla.org/r/155094/#review160270
Attachment #8884172 -
Flags: review?(emilio+bugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•7 years ago
|
||
Servo PR: servo/servo#17636
Comment 12•7 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17abd6800fe9 Don't return None in get_pseudo_style if not probing. r=emilio
![]() |
||
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/17abd6800fe9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Reporter | ||
Comment 14•7 years ago
|
||
Nightly 56 x64 20170709100223 @ Debian Testing (Linux 4.9.0-3-amd64, Radeon RX480) Verified fixed: No crash with opening F12>Inspector on golem.de anymore.
Status: RESOLVED → VERIFIED
![]() |
||
Comment 16•7 years ago
|
||
Questions for ted, copied from bug 1379101 comment 1: - The "alloc::oom::default_oom_handler" makes it sound like an OOM, but it's an expect() failure. Any thoughts on how to make this cleearer? - The crash report doesn't include the expect() argument. Would it be hard to include? Thanks.
Assignee | ||
Comment 17•7 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #16) > Questions for ted, copied from bug 1379101 comment 1: > > - The crash report doesn't include the expect() argument. Would it be hard > to include? expect() argument should be part of the panic message, so the general question is why panic message isn't always included in crash reports. I raised similar question in bug 1275780 comment 17. We probably should file a new bug for this.
Comment 18•7 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #16) > Questions for ted, copied from bug 1379101 comment 1: > > - The "alloc::oom::default_oom_handler" makes it sound like an OOM, but it's > an expect() failure. Any thoughts on how to make this cleearer? In bug 1302078 comment 38 dmajor stated that he thought this was just identical code folding. We could probably add some Socorro signature fiddling to replace both `std::panicking::rust_panic` and `alloc::oom::default_oom_handler` with a special `rust_panic` signature.
You need to log in
before you can comment on or make changes to this bug.
Description
•