Closed
Bug 1378816
Opened 7 years ago
Closed 7 years ago
Talos sessionrestore tests do not produce a stack when the browser hangs
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(firefox55 fixed, firefox56 fixed)
RESOLVED
FIXED
mozilla56
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
See bug 934310: There is a mozharness timeout after 3600 seconds, presumably before Talos has given up on firefox.
I suspect firefox is hung but the Talos timeout is greater than the mozharness timeout, so firefox is not killed by Talos and no crash report is generated.
Assignee | ||
Updated•7 years ago
|
Summary: Some Talos tests do not produce a stack on timeout → Talos sessionrestore tests do not produce a stack when the browser hangs
Assignee | ||
Comment 1•7 years ago
|
||
The sessionrestore test has been using a timeout of 1000000 seconds -- far longer than mozharness will wait for the harness to complete. As a result, when the browser hangs, the harness does not timeout before mozharness kills it, resulting in a timeout failure (reported in bug 934310) without a crash report.
This reduces the timeout to 900 seconds, so that the Talos harness will wait only 15 minutes for each browser session.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e29a7eb9f8298acc6b1fd15eead8d45147336f54 reproduces the hang from bug 934310 with the 900 s timeout and successfully produces crash reports.
Attachment #8884038 -
Flags: review?(ahalberstadt)
Comment 2•7 years ago
|
||
Comment on attachment 8884038 [details] [diff] [review]
use a 900 second browser timeout
Review of attachment 8884038 [details] [diff] [review]:
-----------------------------------------------------------------
Good catch!
Attachment #8884038 -
Flags: review?(ahalberstadt) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b7b3cc327a
Use a reasonable browser timeout in sessionrestore talos test; r=ahal
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 5•7 years ago
|
||
bugherder uplift |
status-firefox55:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•