Closed
Bug 1378820
Opened 7 years ago
Closed 7 years ago
Stop using sdk/clipboard in DevTools
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: sole, Assigned: jdescottes)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file)
No description provided.
Reporter | ||
Comment 1•7 years ago
|
||
Used in devtools/shared/platform/chrome/clipboard.js
Updated•7 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
Assignee | ||
Comment 2•7 years ago
|
||
I'll try to take this one.
The two sdk / clipboard APIs used in devtools are getCurrentFlavors and getData exposed by devtools/shared/platform/clipboard. They are only used by _getClipboardContentForPaste() in devtools/client/inspector/inspector.js
Other consumers of devtools/shared/platform/clipboard use the copyString() API which doesn't rely on the SDK clipboard helper.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Priority: P2 → P1
Target Milestone: --- → Firefox 56
Assignee | ||
Comment 4•7 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9dde9c6d2af89229e17ab68f0b1153bc99bc4ff&selectedJob=119561874
(windows builds failing for some reason)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Gabriel, flagged you for review since the only consumer is in the inspector.
The changeset comment explains in details why I changed the API in this fashion.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8891989 [details]
Bug 1378820 - remove usage of sdk/clipboard in devtools clipboard helper;
https://reviewboard.mozilla.org/r/162996/#review168328
::: devtools/shared/platform/chrome/clipboard.js:53
(Diff revision 2)
> + // Clipboard doesn't contain data in flavor, return null.
> + return null;
> + }
> +
> + // There's no data available, return.
> + if (data.value === null) {
Can we simplify this to be !data.value
Attachment #8891989 -
Flags: review?(gl) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8891989 [details]
Bug 1378820 - remove usage of sdk/clipboard in devtools clipboard helper;
https://reviewboard.mozilla.org/r/162996/#review168328
Thanks for the review!
> Can we simplify this to be !data.value
Updated.
Comment 10•7 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e724df2d505
remove usage of sdk/clipboard in devtools clipboard helper;r=gl
Comment 11•7 years ago
|
||
bugherder |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•