Closed
Bug 1378825
Opened 7 years ago
Closed 7 years ago
Stop using sdk/stylesheet/utils in DevTools
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: zer0, Assigned: Honza)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file)
Used in:
devtools/client/shared/theme-switching.js
devtools/client/webconsole/net/main.js
More details to follow as we triage.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → odvarko
Flags: qe-verify-
Priority: -- → P3
Reporter | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8884237 [details]
Bug 1378825 - Stop using sdk/stylesheet/utils in DevTools;
https://reviewboard.mozilla.org/r/155190/#review160244
We already have this code in `devtools/shared/layout/utils.js` (http://searchfox.org/mozilla-central/source/devtools/shared/layout/utils.js); you can either require this module, or move the stylesheet related code into stylesheet-utils (in that case you have also to replace all the usage of such code that requires layout/utils).
As a side note and personal preference, I would prefer having `stylesheet/utils` instead of the kebab case, to match both the `layout/utils` and the old usage of `stylesheets/utils`, and define a better domain (so that if we need to add or split some logic related to stylesheets, we're still in the same folder, and we don't have to create a `stylesheet-something` in addition to `stylesheet-utils`).
Attachment #8884237 -
Flags: review?(zer0) → review-
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Patch updated, thanks for the comments!
Honza
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [nosdk]
Target Milestone: --- → Firefox 56
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8884237 [details]
Bug 1378825 - Stop using sdk/stylesheet/utils in DevTools;
https://reviewboard.mozilla.org/r/155190/#review163482
looks good to me!
Attachment #8884237 -
Flags: review?(zer0) → review+
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/299ca152f01a
Stop using sdk/stylesheet/utils in DevTools; r=zer0
Comment 7•7 years ago
|
||
bugherder |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•