Soledad Penades [:sole] [:spenades] Reporter
	Description • 7 years ago

Used in:

devtools/server/actors/highlighters/box-model.js
devtools/server/actors/highlighters/css-grid.js
devtools/server/actors/highlighters/css-transform.js
devtools/server/actors/highlighters/geometry-editor.js

More details to follow as we triage.

	Patrick Brosset <:pbro> Assignee
	Comment 1 • 7 years ago

I'll try and do this one now.

	Patrick Brosset <:pbro> Assignee
	Comment 3 • 7 years ago

Tests still pass locally, and I manually tested devtools too, but just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=32363a8ec8e848a79c2677be05c144608d6a6e41

	Soledad Penades [:sole] [:spenades] Reporter
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8888737 [details]
Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

https://reviewboard.mozilla.org/r/159768/#review165118

It looks like a fairly simple change, since thankfully the classes weren't extending any SDK classes! Nice :)

	Soledad Penades [:sole] [:spenades] Reporter
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8888737 [details]
Bug 1378851 - Use ES classes in devtools highlighters rather than SDK heritage module;

https://reviewboard.mozilla.org/r/159770/#review165120

	Pulsebot
	Comment 6 • 7 years ago

Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c43cee08f5b
Use ES classes in devtools highlighters rather than SDK heritage module; r=sole

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/8c43cee08f5b