Closed Bug 1378878 Opened 7 years ago Closed 7 years ago

Notification Service Extension incorrectly updates appPackage in the client record

Categories

(Firefox for iOS :: Firefox Accounts, defect, P1)

Other
iOS
defect

Tracking

()

RESOLVED FIXED
Tracking Status
fxios 8.0+ ---

People

(Reporter: st3fan, Assigned: st3fan)

Details

(Whiteboard: [MobileCore][AutoPush])

Attachments

(1 file)

Both application and notification extension register a client record. The records are mostly similar except for the ID and appPackage: org.mozilla.ios.Fennec org.mozilla.ios.Fennec.NotificationService This results in multiple clients being shown in the device list.
So after investigating more, I don't think this is the case. The confusion came from another bug: the NotificationService extension was updating the client record with its own bundle identifier, $BASEBUNDLEIDENTIFIER.NotifictionService. I think what I saw was not pairs or app and extension, I think what I saw was simply a mix of unique records for unique test clients (i have a lot) that were randomly set to either. The patch attached to this bug fixes the appPackage problem. And bug 1378877 will make sure that the version number in the client record is updated correctly. (It is set to 1.0 in the NotificationService Info.plist, while it should follow the main app's version)
Summary: Both application and notification extension register a client record → Notification Service Extension incorrectly updates appPackage in the client record
This patch sets the appPackage to the main application bundle identifier. This prevents extensions to write their own bundle identifier.
Attachment #8884032 - Flags: review?(jdarcangelo)
Whiteboard: [MobileCore][AutoPush] → [MobileCore][AutoPush][needsuplift]
Status: NEW → ASSIGNED
Attachment #8884032 - Flags: review?(jdarcangelo) → review+
Uplifted to v8.x
Whiteboard: [MobileCore][AutoPush][needsuplift] → [MobileCore][AutoPush]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: