Closed
Bug 1378878
Opened 7 years ago
Closed 7 years ago
Notification Service Extension incorrectly updates appPackage in the client record
Categories
(Firefox for iOS :: Firefox Accounts, defect, P1)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | 8.0+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
(Whiteboard: [MobileCore][AutoPush])
Attachments
(1 file)
Both application and notification extension register a client record.
The records are mostly similar except for the ID and appPackage:
org.mozilla.ios.Fennec
org.mozilla.ios.Fennec.NotificationService
This results in multiple clients being shown in the device list.
Assignee | ||
Comment 1•7 years ago
|
||
So after investigating more, I don't think this is the case. The confusion came from another bug: the NotificationService extension was updating the client record with its own bundle identifier, $BASEBUNDLEIDENTIFIER.NotifictionService.
I think what I saw was not pairs or app and extension, I think what I saw was simply a mix of unique records for unique test clients (i have a lot) that were randomly set to either.
The patch attached to this bug fixes the appPackage problem. And bug 1378877 will make sure that the version number in the client record is updated correctly. (It is set to 1.0 in the NotificationService Info.plist, while it should follow the main app's version)
Assignee | ||
Updated•7 years ago
|
Summary: Both application and notification extension register a client record → Notification Service Extension incorrectly updates appPackage in the client record
Assignee | ||
Comment 2•7 years ago
|
||
This patch sets the appPackage to the main application bundle identifier. This prevents extensions to write their own bundle identifier.
Attachment #8884032 -
Flags: review?(jdarcangelo)
Assignee | ||
Updated•7 years ago
|
Whiteboard: [MobileCore][AutoPush] → [MobileCore][AutoPush][needsuplift]
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Updated•7 years ago
|
Attachment #8884032 -
Flags: review?(jdarcangelo) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Uplifted to v8.x
Whiteboard: [MobileCore][AutoPush][needsuplift] → [MobileCore][AutoPush]
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•