Closed
Bug 1379382
Opened 7 years ago
Closed 7 years ago
Source code links to Rust's standard library are broken
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: xidorn, Assigned: rillian)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
See for example bp-2abff06f-d969-4ba5-845b-a98410170708.
Frame 5 shows core::str::slice_error_fail with libcore/str/mod.rs:2179 linking to https://github.com/rust-lang/rust/blob/03fc9d622e0ea26a3d37f5ab030737fcca6928b9/libcore/str/mod.rs#L2179 which is 404 Not Found.
|
Assignee | |
Comment 1•7 years ago
|
||
That should be `src/libcore/str/mod.rs`.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8884545 [details]
Bug 1379382 - Correct rust srcdir url.
https://reviewboard.mozilla.org/r/155426/#review160766
Attachment #8884545 -
Flags: review?(gps) → review+
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7611340c4d80
Correct rust srcdir url. r=gps
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 7•7 years ago
|
||
Oh, that was dumb. Thanks for fixing that!
|
Reporter | |
Comment 8•7 years ago
|
||
Unfortunately, this is still broken. See for example the top of stack in bp-0625be8a-e875-4e76-85aa-bf53b0170726.
It has link:
> https://github.com/rust-lang/rust/src/blob/0ade339411587887bf01bcfa2e9ae4414c8900d4/liballoc/oom.rs#L26
while the correct link should be:
> https://github.com/rust-lang/rust/blob/0ade339411587887bf01bcfa2e9ae4414c8900d4/src/liballoc/oom.rs#L26
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Updated•7 years ago
|
Flags: needinfo?(giles)
|
|
Assignee | |
Comment 9•7 years ago
|
||
Oops, sorry about that. Hopefully something like this works better.
Assignee: nobody → giles
Flags: needinfo?(giles)
|
|
Assignee | |
Comment 10•7 years ago
|
||
Confirmed fixed with a manual crash in https://crash-stats.mozilla.com/report/index/1f8b7d42-47da-4bda-a3c3-3647e0170731
Thanks to Ted for help verifying!
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•