Closed Bug 1379442 Opened 7 years ago Closed 7 years ago

Inspector info tooltip cause vertical scroll

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: dehghani.m.c, Assigned: abhinav.koppula, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Attached image ff bug.png (deleted) —
Hello, First of all I didn't face this issue before v54. Sometimes (~10% of times that I'm working with Inspector) when I select a node, the tooltip (size info of selected/focused node) doesn't show on the center of the element, instead show on left corner and cause the vertical scroll. (see attached screenshot for more info). p.s: the white area is the content of site and not important. I hover over on the black area (next to the home icon). also I didn't change anything via console. I'm using v54.0.1, I didn't add any dev tools related add-on. Thanks.
Also the selected node doesn't matter, it happens for any node, the tooltip always appear there, the scroll maybe be bigger. btw to fix the issue I have to reload the page (and based on my test always after first reload everything works fine).
I'm sorry but seems like the amount of dev tools bugs is growing up and its too bad for developers like me. and I believe the inspector is one of the most bugy area. based on my other submitted bugs. Please fix dev tools bug as soon as possible, because maybe users could ignore performance issues when browsing the web but issue that affect the job (developing I mean) is critical and ignore them is hard.
Sorry about the delay triaging this bug. From the screenshot, I think this happens on a RTL site, so I tested on a RTL site: https://www.elal.com/he/Israel/Pages/default.aspx I could not reproduce exactly the same issue, but I did have a problem: the nodeinfobar was completely invisible in my case. If I remove the direction:rtl on this page, then it works fine. So it looks like the nodeinfobar is impacted by the writing-mode/direction of the current page. We should fix this. I think we should fix it in \devtools\server\actors\highlighters.css We have a rule for the container of the highighter in this file (at the top), which we use to reset anything the page could be setting that would impact the highlighter's content itself: :-moz-native-anonymous .highlighter-container { /* Content CSS applying to the html element impact the highlighters. To avoid that, possible cases have been set to initial. */ text-transform: initial; text-indent: initial; letter-spacing: initial; word-spacing: initial; color: initial; } I think we should add the following 2 declarations to it: direction: initial; writing-mode: initial;
Mentor: pbrosset
Keywords: good-first-bug
Priority: -- → P2
Hi Patrick, I have created a mozreview-request for this. Please let me know if I should add a test for this. I wasn't sure if tests need to be added for css changes as well since css might keep changing over time.
Comment on attachment 8910103 [details] Bug 1379442 - Fix styling of nodeinfobar on RTL sites by setting writing-mode/direction to 'initial'. https://reviewboard.mozilla.org/r/181586/#review186986 Thank you for the quick fix!
Attachment #8910103 - Flags: review?(pbrosset) → review+
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3da75f798507 Fix styling of nodeinfobar on RTL sites by setting writing-mode/direction to 'initial'. r=pbro
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
No longer blocks: top-inspector-bugs
In FF56.0, I faced this issue in google.com, the direction of this site is LTR, so this bug is not depends on direction of website, I think. So, @Patrick is this bug will be fixed in v57?
Flags: needinfo?(pbrosset)
(In reply to Mehdi from comment #9) > In FF56.0, I faced this issue in google.com, the direction of this site is > LTR, so this bug is not depends on direction of website, I think. Oh ok. This seems like this could be a different bug. Do you mind filing a new bug on bugzilla, with a screenshot of when it happens on google.com, and the steps you took to cause this issue? That would be really helpful! > So, @Patrick is this bug will be fixed in v57? This particular bug here is fixed in v57 yes. But the LTR problem you mentioned on google.com probably not.
Flags: needinfo?(pbrosset)
I filed new bug about google.com, #1412487
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: