gasolin@mozilla.com Assignee
	Description • 7 years ago

as bug 1369287 comment 22, PM decide to use the origin new tab page view

	:Gijs (he/him)
	Comment 3 • 7 years ago
mozreview-review

Comment on attachment 8885150 [details]
Bug 1379860 - shipping origin new tab page view by default;

https://reviewboard.mozilla.org/r/156020/#review161130

	Pulsebot
	Comment 4 • 7 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87ea5fe012f3
shipping origin new tab page view by default;r=Gijs

	Carsten Book [:Tomcat]
	Comment 5 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/87ea5fe012f3

	Marco Castelluccio [:marco]
	Comment 6 • 7 years ago

Is this a backout of the patch from bug 1369287? The commit message is pretty confusing if it is.

	gasolin@mozilla.com Assignee
	Comment 7 • 7 years ago

Marco, it's a partial backout but keeps all the test cases

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 8 • 7 years ago

(In reply to Fred Lin [:gasolin] from comment #7)
> Marco, it's a partial backout but keeps all the test cases

I read Marco's comment on bug 1369287. My assumption was that the part that didn't get backout shouldn't be visible to users but Marco suggest otherwise. Could you clarify that and also back out everything that is user visible? Let's not wait for Marco for filing these bugs.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 9 • 7 years ago

Specifically, bug 1369287 comment 28.

	gasolin@mozilla.com Assignee
	Comment 10 • 7 years ago

The patch is pretty simple and only contains pref change.

Origin pref: 5x3
-> compact pref: 6x2 (bug 1369287)
-> Origin pref: 5x3 (this PR)

I'm sure I backout everything user visible.

	gasolin@mozilla.com Assignee
	Comment 11 • 7 years ago

I found my old screencast recoding in 6/16 (after any of above changes) http://recordit.co/4sk1qfHf37

which shows 4 columns, but it just means the tile is auto-reordered due to the screen width.

	gasolin@mozilla.com Assignee
	Comment 12 • 7 years ago

(I mean 'before' any of above changes)

	gasolin@mozilla.com Assignee
	Comment 13 • 7 years ago

Here's the screen compare between nightly(top) and release(bottom) version, on mackbook air the tile looks the same.

	Marco Castelluccio [:marco]
	Comment 14 • 7 years ago

I've filed bug 1380583, but I can't reproduce in a clean profile, so that's good news.

	Justin [:JW_SoftvisionQA]
	Comment 15 • 7 years ago

I have confirmed this fix on todays Nightly.