Closed
Bug 1379860
Opened 7 years ago
Closed 7 years ago
shipping origin new tab page view by default
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(2 files)
as bug 1369287 comment 22, PM decide to use the origin new tab page view
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [photon-onboarding]
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
Target Milestone: --- → Firefox 56
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8885150 [details] Bug 1379860 - shipping origin new tab page view by default; https://reviewboard.mozilla.org/r/156020/#review161130
Attachment #8885150 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/87ea5fe012f3 shipping origin new tab page view by default;r=Gijs
Keywords: checkin-needed
Comment 6•7 years ago
|
||
Is this a backout of the patch from bug 1369287? The commit message is pretty confusing if it is.
Comment 8•7 years ago
|
||
(In reply to Fred Lin [:gasolin] from comment #7) > Marco, it's a partial backout but keeps all the test cases I read Marco's comment on bug 1369287. My assumption was that the part that didn't get backout shouldn't be visible to users but Marco suggest otherwise. Could you clarify that and also back out everything that is user visible? Let's not wait for Marco for filing these bugs.
Flags: needinfo?(gasolin)
Assignee | ||
Comment 10•7 years ago
|
||
The patch is pretty simple and only contains pref change. Origin pref: 5x3 -> compact pref: 6x2 (bug 1369287) -> Origin pref: 5x3 (this PR) I'm sure I backout everything user visible.
Flags: needinfo?(gasolin)
Assignee | ||
Comment 11•7 years ago
|
||
I found my old screencast recoding in 6/16 (after any of above changes) http://recordit.co/4sk1qfHf37 which shows 4 columns, but it just means the tile is auto-reordered due to the screen width.
Assignee | ||
Comment 13•7 years ago
|
||
Here's the screen compare between nightly(top) and release(bottom) version, on mackbook air the tile looks the same.
Comment 14•7 years ago
|
||
I've filed bug 1380583, but I can't reproduce in a clean profile, so that's good news.
You need to log in
before you can comment on or make changes to this bug.
Description
•