Closed
Bug 1379893
Opened 7 years ago
Closed 7 years ago
stylo: Crash in Gecko_GetStyleContext
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | unaffected |
| firefox56 | --- | fixed |
People
(Reporter: cpeterson, Assigned: bholley)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
|
(deleted),
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-938fcefe-9f19-4297-944c-df6700170710.
=============================================================
9 crashes in Nightly 56.
|
Reporter | |
Updated•7 years ago
|
Blocks: stylo-site-issues
|
||
Comment 1•7 years ago
|
||
From the stack, I guess it crashes at https://searchfox.org/mozilla-central/rev/5dadcbe55b4ddd1e448c06c77390ff6483aa009b/layout/style/ServoBindings.cpp#346 likely that GetShell() returns nullptr, and we tries to call GetPresContext() on that nullptr.
We should probably null-check GetShell since it's prefixed Get.
|
||
Comment 2•7 years ago
|
||
I hit this while browsing https://mozilla.github.io/Fira/
bp-d12c98f0-58bc-4928-b15f-0902c0170711
|
|
||
Comment 3•7 years ago
|
||
I cannot reproduce with just browsing that site.
If it is really because GetShell() returns nullptr, then it might relate more to the site you just navigate from, rather than the site you are browsing.
|
Assignee | |
Comment 4•7 years ago
|
||
This code will go away with bug 1367904. That said, we should probably just land the null-check. I'll attach a patch.
Assignee: nobody → bobbyholley
|
|
Assignee | |
Comment 5•7 years ago
|
||
MozReview-Commit-ID: EWTmhXnl64P
Attachment #8885372 -
Flags: review?(emilio+bugs)
|
||
Updated•7 years ago
|
Attachment #8885372 -
Flags: review?(emilio+bugs) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6accdcc2c44
Null-check the presshell in Gecko_GetStyleContext. r=emilio
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•7 years ago
|
status-firefox54:
--- → unaffected
status-firefox55:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•