Closed Bug 1380458 Opened 7 years ago Closed 7 years ago

WebRender build script generates shaders.rs in a non-deterministic way

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cpeterson, Assigned: glandium)

References

(Blocks 2 open bugs)

Details

Emilio or Nick, glandium says that Stylo's and WebRender's generated bindings code is not cached by sccache. Do you expect rust-bindgen to generate deterministic code that can be cached by sccache between builds (assuming the binding sources didn't change)?
Flags: needinfo?(nfitzgerald)
Flags: needinfo?(emilio+bugs)
WebRender doesn't use rust-bindgen, afaict. Stylo's generated code _should_ be deterministic given exact same input, but I think Mike refers to the properties code, which is bug 1380327, and I just fixed. Mike, is that right?
Depends on: 1380327
Flags: needinfo?(nfitzgerald)
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(emilio+bugs)
There's /something/ that causes webrender to get cache misses on automation, and I'm not sure what it is yet. Bindings code is an hypothesis.
Flags: needinfo?(mh+mozilla)
I remember Ted asking me about this, and then he figured out it was something else, and I don't remember what that something else was. He is on vacation and isn't accepting NIs right now, however.
(It was unrelated to bindgen, however)
Or maybe it was froydnj? Unfortunately, he is also on PTO.
It was gl_generator used by gleam
It's actually unrelated to gleam. Essentially webrender generates shaders.rs from reading a directory list, which can vary between builds. I'm going to do a PR on webrender.
Summary: Determine if Stylo's and WebRender's generated bindings code can be cacheable by sccache → WebRender build script generates shaders.rs in a non-deterministic way
Assignee: nobody → mh+mozilla
Component: Build Config → Graphics: WebRender
(In reply to Mike Hommey [:glandium] from comment #7) > which can vary between builds. *the order of which* can ...
Can we update to webrender tip when this lands there, or do we land just this patch on mozilla-central for now?
Flags: needinfo?(bugmail)
Yeah I'll put together an update to webrender tip in bug 1379604.
Depends on: 1379604
Flags: needinfo?(bugmail)
So this bug can be resolved, right?
Yeah
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
That sure helped! Nice drop around July 14th: https://mzl.la/2vf2HCP Most noticeable on the Windows builds. The osx-cross data is bimodal because of the static analysis builds, we should turn them off (bug 1355118).
You need to log in before you can comment on or make changes to this bug.