Closed
Bug 1380604
Opened 7 years ago
Closed 7 years ago
Race in FetchConsumer
Categories
(Core :: DOM: Service Workers, enhancement)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: catalinb, Assigned: catalinb)
Details
(Keywords: crash)
Attachments
(1 file)
I think there's a race between running BeginConsumeBodyMainThread on MT and ReleaseObject on the worker thread when the worker is shutting down. This causes this crash (with the patches from 1344751):
https://treeherder.mozilla.org/logviewer.html#?job_id=113828957&repo=try&lineNumber=1891
One possible cause is http://searchfox.org/mozilla-central/source/dom/fetch/FetchConsumer.cpp#689 failing to dispatch when called from Notify, since the worker is already in Terminating state.
Assignee | ||
Updated•7 years ago
|
Component: DOM → DOM: Service Workers
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
This might be the winner: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7df0135c9fa768c8ea63f4c849560f2de2b34255
Assignee | ||
Updated•7 years ago
|
Attachment #8886114 -
Flags: review?(amarchesini)
Updated•7 years ago
|
Attachment #8886114 -
Flags: review?(amarchesini) → review+
Pushed by catalin.badea392@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/530b1eb0a548
Use Killing when dispatching the sync runnable in FetchBodyConsumer::ShutDownMainThreadConsuming. r=baku
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•