Closed Bug 1380874 Opened 7 years ago Closed 7 years ago

Signoff UI shown on scheduled change history when signoff not required

Categories

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (frontend)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: alvin.mutisya, Mentored)

References

Details

(Whiteboard: [lang=js][lang=html][good first bug][ready])

Attachments

(1 file)

Screenshot
(deleted), image/png
Details
Attached image Screenshot (deleted) —
Signoffs aren't enabled for Widevine, so all the extra text on the scheduled change history page isn't necessary.
Priority: -- → P3
Whiteboard: [lang=js][lang=html][good first bug][ready]
Mentor: bhearsum
We should probably remove the signoff/revoke buttons for all history, but leave the required/given signoffs for things that have them.
Hi, I was interested in working on this bug , but i just want to know what would be the outcome if the signoff/revoke buttons are removed. There may be other files getting affected from this change.
Hi Ben, I am interested in fixing this bug ,but can you explain more about it.
Assignee: nobody → alvin.mutisya
(In reply to akriti verma from comment #3) > Hi Ben, > I am interested in fixing this bug ,but can you explain more about it. Sorry Akriti, someone else was actually working on this but forgot to assign it. Let me know if you want a hand finding something else to work on.
Hi Ben ,can you help me find another bug? Thanks.
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/f705320369ef6c12d499e881906fcf9936c96f1c bug 1380874: Remove signoff/revoke buttons from history. (#392). r=bhearsum
Alvin, I just realized that the Signoff/Revoke buttons have been removed, but we still show text about signoffs, eg: https://screenshots.firefox.com/XOF2Hkjc2p8gjCnQ/balrog-admin.stage.mozaws.net Could you follow-up with a patch to remove that from the History pages, too?
Flags: needinfo?(alvin.mutisya)
Yes, sure. I'll do a patch(In reply to Ben Hearsum (:bhearsum) from comment #7) > Alvin, I just realized that the Signoff/Revoke buttons have been removed, > but we still show text about signoffs, eg: > https://screenshots.firefox.com/XOF2Hkjc2p8gjCnQ/balrog-admin.stage.mozaws. > net > > Could you follow-up with a patch to remove that from the History pages, too?
Flags: needinfo?(alvin.mutisya)
The initial part of this is in production.
Are you planning to finish this up, Alvin?
Flags: needinfo?(alvin.mutisya)
Yes, I having challenges reproducing it locally though.
Flags: needinfo?(alvin.mutisya)
Turns out that I can't reproduce this anymore - it must've been fixed by some other bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/6c3fa23a9334100ec8804b345f23fcfeb597bae9 bug 1380874: Remove signoff text from history (#410). r=bhearsum
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: