Closed Bug 1381951 Opened 7 years ago Closed 6 years ago

[macOS X] Keyboard shortcut for Preferences can be blocked by websites

Categories

(Firefox :: Settings UI, defect, P4)

Product:
Firefox
Component:
Settings UI
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: rfeeley, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1381951 - reserve preferences shortcut on mac, r?dao
(deleted), text/x-phabricator-request
Details
STEPS TO REPRODUCE 1. Have a few tabs open 2. Pin one or more 3. Select the pinned tab 3. On the keyboard enter ⌘-, (command-comma) EXCEPTED RESULT - Preferences opens ACTUAL RESULT - Nothing happens except the Nightly menu flashes (as if Preferences has been selected)
Can't reproduce with screenshots.firefox.com in the pinned tab in a clean profile on current nightly. Can you (a) reproduce in a clean profile and/or (b) clarify what you've got in the pinned tab? Also, what version is this on? Bugzilla suggests Firefox 49, which I assume is wrong? I expect the website is what's blocking the shortcut, and that it's unrelated to whether the site is pinned or not.
Flags: needinfo?(rfeeley)
It's Gmail! mail.google.com I can reproduce in a fresh Nightly, if I sign into Gmail. Although it does not look related to being pinned or not.
Flags: needinfo?(rfeeley)
Philipp, up to you if you think we should add cmd-, to the list from bug 1052569 comment 12 on OS X.
Blocks: 1052569
Component: Tabbed Browser → Preferences
Flags: needinfo?(philipp)
Summary: Keyboard shortcut for Preferences does not work on a pinned tab → [macOS X] Keyboard shortcut for Preferences can be blocked by websites
Version: 49 Branch → Trunk
Hmm, is it so important shortcut key for macOS users? I don't think that accessing Preference isn't used so many time and it doesn't make it impossible to open Preferences with keyboard. E.g., you can open Preferences after switching active tab or moving focus to chrome UI. If we make web pages not to use too many key combinations, they cannot use custom shortcut key since remaining key combinations will become only not easy to press.
Cmd-, works fine in Chrome and Safari (on Gmail), but fails in Firefox (on Gmail). All on OS X 10.12.6.
Also, there's a UX bug whether you choose to permit websites to override Preferences or not: the 'Firefox' menu title in the menu bar highlights blue briefly when the key is pressed, but then doesn't open the Preferences. So it should either highlight blue and open prefs, or not highlight and not open prefs. It would be very easy to set up a phishing site that looks like about:preferences and bind it to Cmd-, on a bunch of poor-quality websites, especially for entrapping expert users.
I use ⌘-, all the time on macOS. It is (generally) a system-wide keyboard shortcut used across pretty much every app. Websites shouldn't be able to intercept it, I can only imagine how easy it would be to phish the about:preferences#privacy otherwise.
Priority: -- → P4

Clearing needinfo as Phlsa is no longer at Mozilla

Flags: needinfo?(philipp)

This is a one-line fix and comment 7 seems compelling enough a reason to just do this.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

(In reply to :Atoll from comment #6)

Also, there's a UX bug whether you choose to permit websites to override
Preferences or not: the 'Firefox' menu title in the menu bar highlights blue
briefly when the key is pressed, but then doesn't open the Preferences.

So it should either highlight blue and open prefs, or not highlight and not
open prefs.

It would be very easy to set up a phishing site that looks like
about:preferences and bind it to Cmd-, on a bunch of poor-quality websites,
especially for entrapping expert users.

You should file a bug on that.

(In reply to Dão Gottwald [::dao] from comment #11)

You should file a bug on that.

I filed bug 1543202 on your behalf, cheers.

Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bba6d1554446 reserve preferences shortcut on mac, r=dao

https://hg.mozilla.org/mozilla-central/rev/bba6d1554446

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

I noticed that Google Mail and Docs in both Nightly and Chrome seem to respect ⌘-, now (going to prefs). Not sure why.

(In reply to Ryan Feeley [:rfeeley] from comment #15)

I noticed that Google Mail and Docs in both Nightly and Chrome seem to respect ⌘-, now (going to prefs). Not sure why.

I mean, I fixed this bug in Firefox? I'm not sure if you're indicating this was already fixed on gmail/gdocs without my patch, or something else?

Flags: needinfo?(rfeeley)

I just noticed that Chrome now respects ⌘-, too and I'm not sure if this is Chrome's doing or Gmail has stopped overtaking ⌘-,

Flags: needinfo?(rfeeley)
Regressions: 1612254
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: