Closed Bug 1382095 Opened 7 years ago Closed 7 years ago

Mainthread-refcounts on MediaEngineSource in setLastPrefs runnable can sidestep proper cleanup on shutdown.

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(2 files)

Bug 1382095 - Avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown.
(deleted), text/x-review-board-request
jesup
: review+
Details
Bug 1382095 - Fix Refcountable<> helper to avoid size mismatch in the memory leak logging table.
(deleted), text/x-review-board-request
jesup
: review+
Details
May be a potential cause of crashes like bug 1374164. I have a patch to avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown (see bug 1374164 comment 11), that I'll add here.
Comment on attachment 8887764 [details] Bug 1382095 - Fix Refcountable<> helper to avoid size mismatch in the memory leak logging table. https://reviewboard.mozilla.org/r/158682/#review164464
Attachment #8887764 - Flags: review?(rjesup) → review+
Comment on attachment 8887763 [details] Bug 1382095 - Avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown. https://reviewboard.mozilla.org/r/158680/#review164466
Attachment #8887763 - Flags: review?(rjesup) → review+
Pushed by jbruaroey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58e5ecbd98b3 Avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown. r=jesup https://hg.mozilla.org/integration/autoland/rev/5a82cec96940 Fix Refcountable<> helper to avoid size mismatch in the memory leak logging table. r=jesup
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: