Gonk widget support is dead. - bug 1355752 comment 25 is where the decision was made to stop supporting it. - Bug 1357323 removed support for building the Gonk widget code, as well as dom/system/gonk/, hal/gonk/, and some other Gonk-specific code. - Bug 1373478 removed widget/gonk/. This bug is about removing all remaining traces of MOZ_WIDGET_GONK.

As well as the straightforward things, this lets us remove ReadSysFile and WriteSysFile, which in turn lets us remove TestFileUtils.cpp.

Comment on attachment 8887765 [details] [diff] [review] Remove MOZ_WIDGET_GONK from xpcom/ Review of attachment 8887765 [details] [diff] [review]: ----------------------------------------------------------------- Nice cleanup, thanks!

Comment on attachment 8887781 [details] [diff] [review] Remove MOZ_WIDGET_GONK from security/ Review of attachment 8887781 [details] [diff] [review]: ----------------------------------------------------------------- r=me. A couple comments, but no need to change anything. ::: security/manager/pki/nsNSSDialogHelper.cpp @@ -22,5 @@ > -#ifdef MOZ_WIDGET_GONK > - // On b2g devices, we need to proxy the dialog creation & management > - // to Gaia. > - return NS_ERROR_NOT_IMPLEMENTED; > -#endif I'm not officially a peer for this, but it seems reasonable. ::: security/sandbox/linux/broker/SandboxBroker.cpp @@ -459,5 @@ > - static const long nr_setreuid = __NR_setreuid; > - static const long nr_setregid = __NR_setregid; > -#endif > - if (syscall(nr_setregid, getgid(), AID_APP + mChildPid) != 0 || > - syscall(nr_setreuid, getuid(), AID_APP + mChildPid) != 0) { Thanks for reminding me about this. I filed bug 1382246 for some related cleanup. ::: security/sandbox/linux/broker/SandboxBrokerPolicyFactory.cpp @@ +39,5 @@ > SandboxBrokerPolicyFactory::SandboxBrokerPolicyFactory() > { > // Policy entries that are the same in every process go here, and > // are cached over the lifetime of the factory. > +#if defined(MOZ_CONTENT_SANDBOX) FYI, this part is likely to have merge conflicts with bug 1308400.

Comment on attachment 8887795 [details] [diff] [review] Remove MOZ_WIDGET_GONK from ipc/ Review of attachment 8887795 [details] [diff] [review]: ----------------------------------------------------------------- r=me. Again, there are some additional removals that can happen, but those can happen in bug 1316153; this patch is fine as-is. ::: ipc/chromium/src/base/process_util_linux.cc @@ +26,3 @@ > /* > + * We fall back to an arbitrary UID. This is generally the UID for user > + * `nobody', albeit it is not always the case. As far as I know we can rip out *all* the stuff about uids/gids here; B2G was the only platform where it could be used. (I think the “platforms that are not gonk based” comment was a reference to porting B2G to a non-Android-based Linux, like what bug 731498 proposed.) Bug 1316153 already covers this, so I'll comment over there to explicitly mention it. ::: ipc/glue/GeckoChildProcessHost.cpp @@ +76,5 @@ > #endif > > +// We currently don't drop privileges on any platform, because we have to worry > +// about plugins and extensions breaking. > +static const bool kLowRightsSubprocesses = false; This can be constant-propagated, but that cleanup is also part of bug 1316153.

https://hg.mozilla.org/integration/mozilla-inbound/rev/932057f7c805d3630f23ffb60f65a477d892bd90 Bug 1382099 - Remove MOZ_WIDGET_GONK from toolkit/. r=glandium. https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8cce1617e8a1f31521cd26980d9af4cf1cc8cf Bug 1382099 - Remove MOZ_WIDGET_GONK from mozglue/. r=glandium. https://hg.mozilla.org/integration/mozilla-inbound/rev/d11f37fe35f751626aac85b9a5ae0173349204b0 Bug 1382099 - Remove MOZ_WIDGET_GONK from memory/. r=glandium.

As well as the obvious #ifdefs, this allows DOMHwMediaStream to be removed, and also the "phone-state-changed" observer.

As well as the obvious #ifdef stuff, the patch removes TCPSocket::SetAppIdAndBrowser(), which means {TCPSocketParent,TCPServerSocketParent}::{GetAppId,GetInIsolatedMozBrowser}() can also be removed.

Comment on attachment 8888119 [details] [diff] [review] Remove MOZ_WIDGET_GONK from dom/{base,ipc,plugins} Review of attachment 8888119 [details] [diff] [review]: ----------------------------------------------------------------- I'm not a peer of any of this code, but the patch is pretty trivial.

https://hg.mozilla.org/mozilla-central/rev/932057f7c805 https://hg.mozilla.org/mozilla-central/rev/bd8cce1617e8 https://hg.mozilla.org/mozilla-central/rev/d11f37fe35f7

More patches to land.

Comment on attachment 8888163 [details] [diff] [review] Remove MOZ_WIDGET_GONK from several dom/ subdirectories Review of attachment 8888163 [details] [diff] [review]: ----------------------------------------------------------------- I didn't review the dom/network changes, as I don't know anything about that code and it was more complex than deleting some #ifdef blocks. Maybe jdm could review it. ::: dom/html/nsIFormControl.h @@ +279,1 @@ > // On Android/B2G, date/time input appears as a normal text box. Drop the reference to B2G in the comment while you are here, maybe?

https://hg.mozilla.org/integration/mozilla-inbound/rev/9100cfabc9edb9fbf800d3b6181307b9f4bf3fb7 Bug 1382099 - Remove MOZ_WIDGET_GONK from xpcom/. r=erahm. https://hg.mozilla.org/integration/mozilla-inbound/rev/5202dd1a9e218f133380a7fd4b1257d8a99f9c55 Bug 1382099 - Remove MOZ_WIDGET_GONK from security/. r=jld. https://hg.mozilla.org/integration/mozilla-inbound/rev/c6e13d347c58721bdfbcd65a8ae237cf1c6aa43f Bug 1382099 - Remove MOZ_WIDGET_GONK from ipc/. r=jld. https://hg.mozilla.org/integration/mozilla-inbound/rev/aac6fe2703820a894367433708f7b7418fb7ea59 Bug 1382099 - Remove MOZ_WIDGET_GONK from modules/libpref/init/all.js. r=kats. https://hg.mozilla.org/integration/mozilla-inbound/rev/906db68ff15f88d05f50c1354b0fc51cf618bed0 Bug 1382099 - Remove MOZ_WIDGET_GONK from dom/{base,ipc,plugins}. r=mccr8. https://hg.mozilla.org/integration/mozilla-inbound/rev/79bc99d25a3ff9f1129537dddaf169e189a3ddab Bug 1382099 - Remove MOZ_WIDGET_GONK from several dom/ subdirectories. r=mccr8,jdm.

Comment on attachment 8888585 [details] [diff] [review] Remove MOZ_WIDGET_GONK from hal/ Review of attachment 8888585 [details] [diff] [review]: ----------------------------------------------------------------- LGTM but AFAIK most of the power-related methods were only used in MozPowerManager which I doubt we're using on any other platform. From the looks of it it's still living somewhere within the Navigator object: https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/dom/base/Navigator.cpp#1428 We should probably file a bug to remove it.

> We should probably file a bug to remove it. I filed bug 1382955 and made an attempt at a patch.

https://hg.mozilla.org/mozilla-central/rev/9100cfabc9ed https://hg.mozilla.org/mozilla-central/rev/5202dd1a9e21 https://hg.mozilla.org/mozilla-central/rev/c6e13d347c58 https://hg.mozilla.org/mozilla-central/rev/aac6fe270382 https://hg.mozilla.org/mozilla-central/rev/906db68ff15f https://hg.mozilla.org/mozilla-central/rev/79bc99d25a3f

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b593e3e697f71dedf28c6a40e4db6a5b3462ab Bug 1382099 - Remove MOZ_WIDGET_GONK from hal/. r=gsvelto. https://hg.mozilla.org/integration/mozilla-inbound/rev/f645062a665f4da4f1210776f794658a6b0ba858 Bug 1382099 - Remove MOZ_WIDGET_GONK from dom/media/. r=gerald. https://hg.mozilla.org/integration/mozilla-inbound/rev/24df0c0bf28d041bc1b72b401c56f429dccd0f72 Bug 1382099 - Remove MOZ_WIDGET_GONK from media/, uriloader/, widget, /xpfe/. r=snorp.

https://hg.mozilla.org/mozilla-central/rev/c9b593e3e697 https://hg.mozilla.org/mozilla-central/rev/f645062a665f https://hg.mozilla.org/mozilla-central/rev/24df0c0bf28d