Closed
Bug 1382145
Opened 7 years ago
Closed 7 years ago
Update header in customize mode to make it clearer what things are
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Firefox
Toolbars and Customization
Tracking
()
Tracking | Status | |
---|---|---|
firefox57 | --- | verified |
People
(Reporter: annevk, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-structure][photon-l10n-risk])
Attachments
(1 file)
If I accidentally drag and drop a button down into the little overlay window with the blue/purple dragon(?) and information on how to drag, that little overlay window suddenly contains the button and no information on how to drag (nor dragon).
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to Anne (:annevk) from comment #0)
> If I accidentally drag and drop a button down into the little overlay window
> with the blue/purple dragon(?) and information on how to drag, that little
> overlay window suddenly contains the button and no information on how to
> drag (nor dragon).
This is intentional... It's not a "little overlay window", it's the overflow panel (which is empty by default). This is why it points to the overflow button.
I don't understand why it's surprising. If you drag things into the overflow panel, clearly you know how to drag things in/out of it. The illustration is only supposed to show when the panel is empty.
How do you expect this to work?
Flags: needinfo?(annevk)
Assignee | ||
Comment 2•7 years ago
|
||
The text underneath the icon also literally says "drag and drop items *here*".
Reporter | ||
Comment 3•7 years ago
|
||
I guess I just got confused by it. I don't really understand the purpose of that box then given the big ass page where you can also drop stuff...
Flags: needinfo?(annevk)
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Anne (:annevk) from comment #3)
> I guess I just got confused by it. I don't really understand the purpose of
> that box then given the big ass page where you can also drop stuff...
Items you drop in the "big ass page" are gone in normal usage (ie when you exit customize mode, you can't use those buttons/items). Items you drop in the panel will be accessible from the overflow button (>>) at the end of the toolbar (which only appears if there are items in said panel, which there aren't by default). Hence "within reach" (which items in the "big ass page" aren't).
Assignee | ||
Comment 5•7 years ago
|
||
Aaron, anything you think we should change here to try to make this clearer?
Flags: needinfo?(abenson)
Comment 6•7 years ago
|
||
Yeah, lets change the headline to be more instructive. That will have the added benefit of being around when there are items in the overflow panel and we lose our helpful Dragon Drop character.
Change: Additional Tools and Features
To: Drag your favorite items into the toolbar or overflow panel.
Updated InVision spec here: https://mozilla.invisionapp.com/share/WUBRB21NH#/screens/229252091_Customization
Flags: needinfo?(abenson)
Assignee | ||
Updated•7 years ago
|
Blocks: 1352693
Flags: qe-verify+
QA Contact: gwimberly
Summary: Customize should not allow dragging buttons into the information dialog → Update header in customize mode to make it clearer what things are
Whiteboard: [photon-structure][triage]
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Whiteboard: [reserve-photon-structure] → [reserve-photon-structure][photon-l10n-risk]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
Priority: P3 → P1
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8898735 -
Flags: review?(abenson)
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8898735 [details]
Bug 1382145 - update customize mode header to be clearer,
https://reviewboard.mozilla.org/r/170146/#review175276
::: browser/locales/en-US/chrome/browser/browser.dtd:847
(Diff revision 1)
> <!ENTITY social.directory.text "You can activate Share services from the directory.">
> <!ENTITY social.directory.button "Take me there!">
> <!ENTITY social.directory.introText "Click on a service to add it to &brandShortName;.">
> <!ENTITY social.directory.viewmore.text "View More">
>
> -<!ENTITY customizeMode.menuAndToolbars.header2 "Additional Tools and Features">
> +<!ENTITY customizeMode.menuAndToolbars.header3 "Drag your favorite items into the toolbar or overflow panel.">
Note that we call the overflow panel "Overflow Menu" in the context menus ("Pin to Overflow Menu" etc.). Should we use 'menu' here too, or update the context menus to say 'Panel', or are we fine with saying panel here and 'menu' in the context menu?
Comment 9•7 years ago
|
||
Oops, I'm mixing up my terms :) Change this one from panel -> menu:
"Drag your favorite items into the toolbar or overflow menu."
Comment hidden (mozreview-request) |
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8898735 [details]
Bug 1382145 - update customize mode header to be clearer,
https://reviewboard.mozilla.org/r/170146/#review175278
LGTM
Attachment #8898735 -
Flags: review?(abenson) → review+
Comment 12•7 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/54bd21194e6f
update customize mode header to be clearer, r=abenson
Comment 13•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 14•7 years ago
|
||
I reproduced the behavior described in comment 0. I can confirm this issue is fixed, I verified using Fx 57.0b7, on Windows 10 x64 and mac OS X 10.12.6.
You need to log in
before you can comment on or make changes to this bug.
Description
•