We should change Telemetry code to use the preferences defined in the TelemetryUtils.jsm file rather than redefining them in TelemetryReportingPolicy.jsm.

Comment on attachment 8890354 [details] [diff] [review] Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm Review of attachment 8890354 [details] [diff] [review]: ----------------------------------------------------------------- This looks good with the nit below addressed. ::: toolkit/components/telemetry/TelemetryUtils.jsm @@ +49,5 @@ > CurrentPolicyVersion: "datareporting.policy.currentPolicyVersion", > DataSubmissionEnabled: "datareporting.policy.dataSubmissionEnabled", > FhrUploadEnabled: "datareporting.healthreport.uploadEnabled", > MinimumPolicyVersion: "datareporting.policy.minimumPolicyVersion", > + FirstRunURL: "datareporting.policy.firstRunURL", Can you move this one near FirstRun?

(In reply to Alessio Placitelli [:Dexter] from comment #2) > Comment on attachment 8890354 [details] [diff] [review] > Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm > > Review of attachment 8890354 [details] [diff] [review]: > ----------------------------------------------------------------- > > This looks good with the nit below addressed. > > ::: toolkit/components/telemetry/TelemetryUtils.jsm > @@ +49,5 @@ > > CurrentPolicyVersion: "datareporting.policy.currentPolicyVersion", > > DataSubmissionEnabled: "datareporting.policy.dataSubmissionEnabled", > > FhrUploadEnabled: "datareporting.healthreport.uploadEnabled", > > MinimumPolicyVersion: "datareporting.policy.minimumPolicyVersion", > > + FirstRunURL: "datareporting.policy.firstRunURL", > > Can you move this one near FirstRun? Now the prefs are ordered by branch name. "toolkit.telemetry.*" first, then "datareporting.policy.*". FirstRun belongs to the first group, and FirstRunURL to the second one. Should I break this order to move FirstRunURL near FirstRun?

(In reply to Alejandro Rodriguez Salamanca from comment #3) > (In reply to Alessio Placitelli [:Dexter] from comment #2) > > Comment on attachment 8890354 [details] [diff] [review] > > Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm > > > > Review of attachment 8890354 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > This looks good with the nit below addressed. > > > > ::: toolkit/components/telemetry/TelemetryUtils.jsm > > @@ +49,5 @@ > > > CurrentPolicyVersion: "datareporting.policy.currentPolicyVersion", > > > DataSubmissionEnabled: "datareporting.policy.dataSubmissionEnabled", > > > FhrUploadEnabled: "datareporting.healthreport.uploadEnabled", > > > MinimumPolicyVersion: "datareporting.policy.minimumPolicyVersion", > > > + FirstRunURL: "datareporting.policy.firstRunURL", > > > > Can you move this one near FirstRun? > > Now the prefs are ordered by branch name. "toolkit.telemetry.*" first, then > "datareporting.policy.*". FirstRun belongs to the first group, and > FirstRunURL to the second one. Should I break this order to move FirstRunURL > near FirstRun? Nope, good point.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a86a44628486dbe2f350ce6bbdf86564d1fa32d9 Bug 1382196 - Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm. r=dexter