Closed Bug 1382219 Opened 7 years ago Closed 7 years ago

Crash in memcpy | mozilla::loader::OutputBuffer::codeString

Categories

(Core :: JavaScript Engine, defect)

x86
Windows 7
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: jesup, Assigned: kmag)

References

Details

(4 keywords)

Crash Data

NI naveed for triage
Flags: needinfo?(nihsanullah)
Group: core-security → javascript-core-security
This is probably a regression from Kris's preloader work.
Flags: needinfo?(nihsanullah) → needinfo?(kmaglione+bmo)
The only way I can think of that this might happen is if we invalidate the startup cache (probably because of an extension installation) in the middle of a cache write operation, and free cached scripts before they're encoded. There's supposed to be locking to prevent that, but there are separate monitors for the cache write operation and ordinary cache manipulation, and the write thread only holds one of them.
Flags: needinfo?(kmaglione+bmo)
Assignee: nobody → kmaglione+bmo
Kris, will 1382329 help here?
Flags: needinfo?(kmaglione+bmo)
Last crashes on crash-stats are from 55.0b12, which strongly supports this having been fixed by bug 1382329 (shipped in b13).
Status: NEW → RESOLVED
Closed: 7 years ago
Depends on: 1382329
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Group: javascript-core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.